<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 13, 2015 at 10:27 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: shankare<br>
Date: Sat Mar 14 00:27:01 2015<br>
New Revision: 232253<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232253&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=232253&view=rev</a><br>
Log:<br>
[ELF] Change few static functions.<br>
<br>
Functions hasOutputSegment/maybeGetSOName doesnot need not be static.<br></blockquote><div><br>If something doesn't access member state, it should probably remain a static function... it seems confusing to pass an unused parameter (even if it's the implicit 'this' parameter that's unused).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h<br>
    lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=232253&r1=232252&r2=232253&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=232253&r1=232252&r2=232253&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Sat Mar 14 00:27:01 2015<br>
@@ -193,7 +193,7 @@ public:<br>
<br>
   /// \brief Returns true/false depending on whether the section has a Output<br>
   //         segment or not<br>
-  static bool hasOutputSegment(Section<ELFT> *section);<br>
+  bool hasOutputSegment(Section<ELFT> *section);<br>
<br>
   // Adds an atom to the section<br>
   ErrorOr<const lld::AtomLayout *> addAtom(const Atom *atom) override;<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h?rev=232253&r1=232252&r2=232253&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h?rev=232253&r1=232252&r2=232253&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.h Sat Mar 14 00:27:01 2015<br>
@@ -146,7 +146,7 @@ protected:<br>
   /// @}<br>
<br>
 private:<br>
-  static StringRef maybeGetSOName(Node *node);<br>
+  StringRef maybeGetSOName(Node *node);<br>
 };<br>
<br>
 //===----------------------------------------------------------------------===//<br>
@@ -298,7 +298,7 @@ void OutputELFWriter<ELFT>::assignSectio<br>
   _layout.assignFileOffsetsForMiscSections();<br>
   for (auto sec : _layout.sections())<br>
     if (auto section = dyn_cast<Section<ELFT>>(sec))<br>
-      if (!DefaultLayout<ELFT>::hasOutputSegment(section))<br>
+      if (!_layout.hasOutputSegment(section))<br>
         _shdrtab->updateSection(section);<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>