<div dir="ltr">The class you used here uses this pattern, does that make sense for this instruction? Should we have an empty pattern for this?<div><br></div><div><span style="color:rgb(0,0,0);font-family:monospace;font-size:medium;white-space:pre"> [(set RC:$dst, (VT (X86VBroadcast (ld_frag addr:$src))))]</span><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 11, 2015 at 11:06 AM, Juergen Ributzka <span dir="ltr"><<a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Yes. It generates now "vinsertf128<span style="white-space:pre-wrap"> </span>$1, %xmm0, %ymm0, %ymm0”, which doesn’t go through memory anymore.</div><div><div class="h5"><br><div><blockquote type="cite"><div>On Mar 11, 2015, at 10:59 AM, Craig Topper <<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>> wrote:</div><br><div><div dir="ltr">But when you removed it, it got replace with a shuffle right? What instruction does that shuffle generate in llvm?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 11, 2015 at 10:50 AM, Juergen Ributzka <span dir="ltr"><<a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>There has never been a shuffle pattern that used this instruction. The only way you would get this instruction was by specifying the intrinsic. I removed the intrinsic in r231182, because we (clang) are not generating it anymore.</div><div><div><br><div><blockquote type="cite"><div>On Mar 11, 2015, at 10:42 AM, Craig Topper <<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Does the backend not emit this instruction for the corresponding shuffle pattern?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 11, 2015 at 10:29 AM, Juergen Ributzka <span dir="ltr"><<a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ributzka<br>
Date: Wed Mar 11 12:29:03 2015<br>
New Revision: 231945<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231945&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231945&view=rev</a><br>
Log:<br>
Add the "vbroadcasti128" instruction back.<br>
<br>
This is a follow-up to r231182. This adds the "vbroadcasti128" instruction<br>
back, but without the intrinsic mapping. Also add a test to check the<br>
instriction encoding.<br>
<br>
This is related to <a>rdar://problem/18742778</a>.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86InstrSSE.td<br>
llvm/trunk/test/MC/X86/x86_64-avx-encoding.s<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrSSE.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=231945&r1=231944&r2=231945&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=231945&r1=231944&r2=231945&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrSSE.td (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrSSE.td Wed Mar 11 12:29:03 2015<br>
@@ -7833,6 +7833,11 @@ def VBROADCASTSDYrr : avx2_broadcast_re<br>
int_x86_avx2_vbroadcast_sd_pd_256,<br>
WriteFShuffle256>, VEX_L;<br>
<br>
+let Predicates = [HasAVX2] in<br>
+def VBROADCASTI128 : avx_broadcast_no_int<0x5A, "vbroadcasti128", VR256,<br>
+ i128mem, v4i64, loadv2i64,<br>
+ WriteLoad>, VEX_L;<br>
+<br>
let Predicates = [HasAVX] in<br>
def : Pat<(int_x86_avx_vbroadcastf128_ps_256 addr:$src),<br>
(VBROADCASTF128 addr:$src)>;<br>
<br>
Modified: llvm/trunk/test/MC/X86/x86_64-avx-encoding.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/x86_64-avx-encoding.s?rev=231945&r1=231944&r2=231945&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/x86_64-avx-encoding.s?rev=231945&r1=231944&r2=231945&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/X86/x86_64-avx-encoding.s (original)<br>
+++ llvm/trunk/test/MC/X86/x86_64-avx-encoding.s Wed Mar 11 12:29:03 2015<br>
@@ -3724,6 +3724,10 @@ vdivpd -4(%rcx,%rbx,8), %xmm10, %xmm11<br>
// CHECK: encoding: [0xc4,0x63,0x2d,0x40,0x18,0x03]<br>
vdpps $3, (%rax), %ymm10, %ymm11<br>
<br>
+// CHECK: vbroadcasti128 (%rax), %ymm12<br>
+// CHECK: encoding: [0xc4,0x62,0x7d,0x5a,0x20]<br>
+ vbroadcasti128 (%rax), %ymm12<br>
+<br>
// CHECK: vbroadcastf128 (%rax), %ymm12<br>
// CHECK: encoding: [0xc4,0x62,0x7d,0x1a,0x20]<br>
vbroadcastf128 (%rax), %ymm12<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>~Craig</div>
</div>
</div></blockquote></div><br></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>~Craig</div>
</div>
</div></blockquote></div><br></div></div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>