<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 6, 2015, at 3:33 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">So they're mostly read only, why change the values rather than create a new one?<br class=""></div></div></blockquote><div><br class=""></div><div>Simply convenience. It’s easier to store a DIEInteger * and just call setValue() on it than to store a reference to the place where the DIEInteger was used to be able to replace it. I could go with the second option, but I’d need to add more complicated API to DIE to be able to change an attribute’s value.</div><div><br class=""></div><div>Do you want me to do that?</div><div><br class=""></div><div>Fred</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">-eric<br class=""></div><br class=""><div class="gmail_quote">On Fri, Mar 6, 2015 at 3:32 PM Frederic Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: friss<br class="">
Date: Fri Mar 6 17:22:46 2015<br class="">
New Revision: 231529<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231529&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>project?rev=231529&view=rev</a><br class="">
Log:<br class="">
Add DIEInteger::setValue() method.<br class="">
<br class="">
dsymutil needs to 'patch' attribute values after creating them. Just<br class="">
add this trivial capability.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/<u class=""></u>CodeGen/DIE.h<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/<u class=""></u>CodeGen/DIE.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/DIE.h?rev=231529&r1=231528&r2=231529&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>project/llvm/trunk/include/<u class=""></u>llvm/CodeGen/DIE.h?rev=231529&<u class=""></u>r1=231528&r2=231529&view=diff</a><br class="">
==============================<u class=""></u>==============================<u class=""></u>==================<br class="">
--- llvm/trunk/include/llvm/<u class=""></u>CodeGen/DIE.h (original)<br class="">
+++ llvm/trunk/include/llvm/<u class=""></u>CodeGen/DIE.h Fri Mar 6 17:22:46 2015<br class="">
@@ -278,6 +278,7 @@ public:<br class="">
void EmitValue(const AsmPrinter *AP, dwarf::Form Form) const override;<br class="">
<br class="">
uint64_t getValue() const { return Integer; }<br class="">
+ void setValue(uint64_t Val) { Integer = Val; }<br class="">
<br class="">
/// SizeOf - Determine size of integer value in bytes.<br class="">
///<br class="">
<br class="">
<br class="">
______________________________<u class=""></u>_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>