<div dir="ltr"><div>+  assert(false && "Couldn't find loop");<br><br></div>llvm_unreachable?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 6, 2015 at 2:39 AM, Daniel Jasper <span dir="ltr"><<a href="mailto:djasper@google.com" target="_blank">djasper@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: djasper<br>
Date: Fri Mar  6 04:39:14 2015<br>
New Revision: 231459<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231459&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231459&view=rev</a><br>
Log:<br>
Change the way in which error case is being handled.<br>
<br>
Specifically this:<br>
* Prevents an "unused" warning in non-assert builds.<br>
* In that error case return with out removing a child loop instead of<br>
  looping forever.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp?rev=231459&r1=231458&r2=231459&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp?rev=231459&r1=231458&r2=231459&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/LoopInterchange.cpp Fri Mar  6 04:39:14 2015<br>
@@ -901,14 +901,16 @@ bool LoopInterchangeProfitability::isPro<br>
<br>
 void LoopInterchangeTransform::removeChildLoop(Loop *OuterLoop,<br>
                                                Loop *InnerLoop) {<br>
-  for (Loop::iterator I = OuterLoop->begin(), E = OuterLoop->end();; ++I) {<br>
-    assert(I != E && "Couldn't find loop");<br>
+  for (Loop::iterator I = OuterLoop->begin(), E = OuterLoop->end(); I != E;<br>
+       ++I) {<br>
     if (*I == InnerLoop) {<br>
       OuterLoop->removeChildLoop(I);<br>
       return;<br>
     }<br>
   }<br>
+  assert(false && "Couldn't find loop");<br>
 }<br>
+<br>
 void LoopInterchangeTransform::restructureLoops(Loop *InnerLoop,<br>
                                                 Loop *OuterLoop) {<br>
   Loop *OuterLoopParent = OuterLoop->getParentLoop();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>