<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 10:33 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I have delta running. I will upload a reduced testcase in one sec.<br></blockquote><div><br>No worries - if it's the same assertion text on the same file I'm happy enough to assume it's the same thing.<br><br>Hand reducing the test case provided in PR22791 got me to this:<br><br><div>template <typename></div><div>struct foo {</div><div>protected:</div><div> ~foo() = default;</div><div>};</div><div><br></div><div>struct x : foo<int> {</div><div> x() {}</div><div>};</div><div><br></div><div>template struct foo<int>;<br><br>I'll file a clang bug with this shortly & can workaround the issue by using {} instead of "= default" in this particular context.</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
On 4 March 2015 at 10:15, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
> Your bug report doesn't actually mention the crash, but a related (I believe<br>
> duplicate) bug report did<br>
><br>
> <a href="http://llvm.org/bugs/show_bug.cgi?id=22791" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=22791</a><br>
><br>
> clang::CodeGen::CodeGenFunction::EnterDtorCleanups(const<br>
> clang::CXXDestructorDecl *, clang::CXXDtorType): Assertion<br>
> `(!DD->isTrivial() || DD->hasAttr<DLLExportAttr>()) && "Should not emit dtor<br>
> epilogue for non-exported trivial dtor!"' failed.<br>
><br>
> & yes, I believe my commit (that Takumi reverted - thanks!) did cause this -<br>
> looks like I tickled a clang bug. I'll work on a reproduction/reduction &<br>
> figure out how to workaround it so I can resubmit this change..<br>
><br>
><br>
> On Wed, Mar 4, 2015 at 8:39 AM, Rafael Espíndola<br>
> <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
>><br>
>> Was the error the one in:<br>
>><br>
>> <a href="http://llvm.org/bugs/show_bug.cgi?id=22789" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=22789</a><br>
>><br>
>> ?<br>
>><br>
>> On 4 March 2015 at 08:24, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br>
>> > Author: chapuni<br>
>> > Date: Wed Mar 4 10:24:40 2015<br>
>> > New Revision: 231254<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231254&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231254&view=rev</a><br>
>> > Log:<br>
>> > Revert r231221, "Devirtualize ~parser<T> by making it protected in base<br>
>> > classes and making derived classes final"<br>
>> ><br>
>> > It broke seflhosting.<br>
>> ><br>
>> > Modified:<br>
>> > llvm/trunk/include/llvm/Support/CommandLine.h<br>
>> ><br>
>> > Modified: llvm/trunk/include/llvm/Support/CommandLine.h<br>
>> > URL:<br>
>> > <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CommandLine.h?rev=231254&r1=231253&r2=231254&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CommandLine.h?rev=231254&r1=231253&r2=231254&view=diff</a><br>
>> ><br>
>> > ==============================================================================<br>
>> > --- llvm/trunk/include/llvm/Support/CommandLine.h (original)<br>
>> > +++ llvm/trunk/include/llvm/Support/CommandLine.h Wed Mar 4 10:24:40<br>
>> > 2015<br>
>> > @@ -714,6 +714,7 @@ class basic_parser_impl { // non-templat<br>
>> > public:<br>
>> > basic_parser_impl(Option &O) {}<br>
>> ><br>
>> > + virtual ~basic_parser_impl() {}<br>
>> ><br>
>> > enum ValueExpected getValueExpectedFlagDefault() const {<br>
>> > return ValueRequired;<br>
>> > @@ -742,7 +743,6 @@ public:<br>
>> > virtual void anchor();<br>
>> ><br>
>> > protected:<br>
>> > - ~basic_parser_impl() = default;<br>
>> > // A helper for basic_parser::printOptionDiff.<br>
>> > void printOptionName(const Option &O, size_t GlobalWidth) const;<br>
>> > };<br>
>> > @@ -755,15 +755,12 @@ public:<br>
>> > basic_parser(Option &O) : basic_parser_impl(O) {}<br>
>> > typedef DataType parser_data_type;<br>
>> > typedef OptionValue<DataType> OptVal;<br>
>> > -<br>
>> > -protected:<br>
>> > - ~basic_parser() = default;<br>
>> > };<br>
>> ><br>
>> > //--------------------------------------------------<br>
>> > // parser<bool><br>
>> > //<br>
>> > -template <> class parser<bool> final : public basic_parser<bool> {<br>
>> > +template <> class parser<bool> : public basic_parser<bool> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -790,8 +787,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> ><br>
>> > //--------------------------------------------------<br>
>> > // parser<boolOrDefault><br>
>> > -template <><br>
>> > -class parser<boolOrDefault> final : public basic_parser<boolOrDefault><br>
>> > {<br>
>> > +template <> class parser<boolOrDefault> : public<br>
>> > basic_parser<boolOrDefault> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -817,7 +813,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<int><br>
>> > //<br>
>> > -template <> class parser<int> final : public basic_parser<int> {<br>
>> > +template <> class parser<int> : public basic_parser<int> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -839,7 +835,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<unsigned><br>
>> > //<br>
>> > -template <> class parser<unsigned> final : public<br>
>> > basic_parser<unsigned> {<br>
>> > +template <> class parser<unsigned> : public basic_parser<unsigned> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -862,8 +858,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > // parser<unsigned long long><br>
>> > //<br>
>> > template <><br>
>> > -class parser<unsigned long long> final<br>
>> > - : public basic_parser<unsigned long long> {<br>
>> > +class parser<unsigned long long> : public basic_parser<unsigned long<br>
>> > long> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -886,7 +881,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<double><br>
>> > //<br>
>> > -template <> class parser<double> final : public basic_parser<double> {<br>
>> > +template <> class parser<double> : public basic_parser<double> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -908,7 +903,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<float><br>
>> > //<br>
>> > -template <> class parser<float> final : public basic_parser<float> {<br>
>> > +template <> class parser<float> : public basic_parser<float> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -930,7 +925,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<std::string><br>
>> > //<br>
>> > -template <> class parser<std::string> final : public<br>
>> > basic_parser<std::string> {<br>
>> > +template <> class parser<std::string> : public<br>
>> > basic_parser<std::string> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> > @@ -955,7 +950,7 @@ EXTERN_TEMPLATE_INSTANTIATION(class basi<br>
>> > //--------------------------------------------------<br>
>> > // parser<char><br>
>> > //<br>
>> > -template <> class parser<char> final : public basic_parser<char> {<br>
>> > +template <> class parser<char> : public basic_parser<char> {<br>
>> > public:<br>
>> > parser(Option &O) : basic_parser(O) {}<br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>