<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 4, 2015, at 10:09 PM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com" class="">Paul_Robinson@playstation.sony.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">-----Original Message-----<br class="">From:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits-bounces@cs.uiuc.edu" class="">llvm-commits-bounces@cs.uiuc.edu</a><span class="Apple-converted-space"> </span>[mailto:llvm-commits-<br class=""><a href="mailto:bounces@cs.uiuc.edu" class="">bounces@cs.uiuc.edu</a>] On Behalf Of Frederic Riss<br class="">Sent: Wednesday, March 04, 2015 2:08 PM<br class="">To:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">Subject: [llvm] r231298 - Teach DIEInteger to emit FORM_strp and<br class="">FORM_ref_addr attributes.<br class=""><br class="">Author: friss<br class="">Date: Wed Mar 4 16:07:36 2015<br class="">New Revision: 231298<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231298&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=231298&view=rev</a><br class="">Log:<br class="">Teach DIEInteger to emit FORM_strp and FORM_ref_addr attributes.<br class=""><br class="">To be used/tested by llvm-dsymutil. (llvm-dsymutil does a 'static' link,<br class="">no need for relocations for most things, so it'll just emit raw integers<br class="">for most attributes)<br class=""><br class="">Modified:<br class=""> llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp<br class=""><br class="">Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp<br class="">URL: <a href="http://llvm.org/viewvc/llvm-" class="">http://llvm.org/viewvc/llvm-</a><br class="">project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp?rev=231298&r1=231297&r2=<br class="">231298&view=diff<br class="">==========================================================================<br class="">====<br class="">--- llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp (original)<br class="">+++ llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp Wed Mar 4 16:07:36 2015<br class="">@@ -218,6 +218,7 @@ void DIEInteger::EmitValue(const AsmPrin<br class=""> case dwarf::DW_FORM_ref2: // Fall thru<br class=""> case dwarf::DW_FORM_data2: Size = 2; break;<br class=""> case dwarf::DW_FORM_sec_offset: // Fall thru<br class="">+ case dwarf::DW_FORM_strp: // Fall thru<br class=""> case dwarf::DW_FORM_ref4: // Fall thru<br class=""> case dwarf::DW_FORM_data4: Size = 4; break;<br class=""> case dwarf::DW_FORM_ref8: // Fall thru<br class="">@@ -229,6 +230,9 @@ void DIEInteger::EmitValue(const AsmPrin<br class=""> case dwarf::DW_FORM_sdata: Asm->EmitSLEB128(Integer); return;<br class=""> case dwarf::DW_FORM_addr:<br class=""> Size = Asm->getDataLayout().getPointerSize(); break;<br class="">+ case dwarf::DW_FORM_ref_addr:<br class="">+ Size = SizeOf(Asm, dwarf::DW_FORM_ref_addr);<br class="">+ break;<br class=""> default: llvm_unreachable("DIE Value form not supported yet");<br class=""> }<br class=""> Asm->OutStreamer.EmitIntValue(Integer, Size);<br class="">@@ -245,6 +249,7 @@ unsigned DIEInteger::SizeOf(const AsmPri<br class=""> case dwarf::DW_FORM_ref2: // Fall thru<br class=""> case dwarf::DW_FORM_data2: return sizeof(int16_t);<br class=""> case dwarf::DW_FORM_sec_offset: // Fall thru<br class="">+ case dwarf::DW_FORM_strp: // Fall thru<br class=""> case dwarf::DW_FORM_ref4: // Fall thru<br class=""> case dwarf::DW_FORM_data4: return sizeof(int32_t);<br class=""> case dwarf::DW_FORM_ref8: // Fall thru<br class="">@@ -255,6 +260,11 @@ unsigned DIEInteger::SizeOf(const AsmPri<br class=""> case dwarf::DW_FORM_udata: return getULEB128Size(Integer);<br class=""> case dwarf::DW_FORM_sdata: return getSLEB128Size(Integer);<br class=""> case dwarf::DW_FORM_addr: return AP->getDataLayout().getPointerSize();<br class="">+ case dwarf::DW_FORM_ref_addr:<br class="">+ if (AP->OutStreamer.getContext().getDwarfVersion() == 2)<br class="">+ return AP->getDataLayout().getPointerSize();<br class="">+ return sizeof(int32_t);<br class="">+ break;<br class=""></blockquote><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Don't need break after return.</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></div></blockquote><div><br class=""></div><div><div style="margin: 0px;" class="">r231353, thanks!</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">Fred</div></div><br class=""><blockquote type="cite" class=""><div class=""><div style="" class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--paulr</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> default: llvm_unreachable("DIE Value form not supported yet");<br class=""> }<br class="">}<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></body></html>