<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 4:15 PM, Robinson, Paul <span dir="ltr"><<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">r231322.  Didn't Phab used to put the revision number in its email?<br></blockquote><div><br>Yeah, not sure - maybe only if it submits the patch? (arc patch or somesuch) rather than if it detects the commit? Don't know.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-">llvm-commits-</a><br>
> <a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Paul Robinson<br>
> Sent: Wednesday, March 04, 2015 4:11 PM<br>
> To: <a href="mailto:echristo@gmail.com">echristo@gmail.com</a>; <a href="mailto:aprantl@apple.com">aprantl@apple.com</a>; <a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a><br>
> Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> Subject: Re: [PATCH] Turn off .debug_pubnames/pubtypes for PS4.<br>
><br>
> REPOSITORY<br>
>   rL LLVM<br>
><br>
> <a href="http://reviews.llvm.org/D8067" target="_blank">http://reviews.llvm.org/D8067</a><br>
><br>
> Files:<br>
>   llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
>   llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll<br>
><br>
> Index: llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll<br>
> ===================================================================<br>
> --- llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll<br>
> +++ llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll<br>
> @@ -1,7 +1,9 @@<br>
>  ; RUN: llc -mtriple=x86_64-pc-linux-gnu -filetype=obj -o %t.o < %s<br>
>  ; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-<br>
> prefix=LINUX %s<br>
>  ; RUN: llc -mtriple=x86_64-apple-darwin12 -filetype=obj -o %t.o < %s<br>
> -; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-<br>
> prefix=DARWIN %s<br>
> +; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-<br>
> prefix=NOPUB %s<br>
> +; RUN: llc -mtriple=x86_64-scei-ps4 -filetype=obj -o %t.o < %s<br>
> +; RUN: llvm-dwarfdump -debug-dump=pubnames %t.o | FileCheck --check-<br>
> prefix=NOPUB %s<br>
>  ; ModuleID = 'dwarf-public-names.cpp'<br>
>  ;<br>
>  ; Generated from:<br>
> @@ -35,9 +37,9 @@<br>
>  ;   int global_namespace_variable = 1;<br>
>  ; }<br>
><br>
> -; Darwin shouldn't be generating the section by default<br>
> -; DARWIN: debug_pubnames<br>
> -; DARWIN: {{^$}}<br>
> +; Darwin and PS4 shouldn't be generating the section by default<br>
> +; NOPUB: debug_pubnames<br>
> +; NOPUB: {{^$}}<br>
><br>
>  ; Skip the output to the header of the pubnames section.<br>
>  ; LINUX: debug_pubnames<br>
> Index: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
> ===================================================================<br>
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
> @@ -212,7 +212,7 @@<br>
>    CurMI = nullptr;<br>
><br>
>    // Turn on accelerator tables for Darwin by default, pubnames by<br>
> -  // default for non-Darwin, and handle split dwarf.<br>
> +  // default for non-Darwin/PS4, and handle split dwarf.<br>
>    if (DwarfAccelTables == Default)<br>
>      HasDwarfAccelTables = IsDarwin;<br>
>    else<br>
> @@ -224,7 +224,7 @@<br>
>      HasSplitDwarf = SplitDwarf == Enable;<br>
><br>
>    if (DwarfPubSections == Default)<br>
> -    HasDwarfPubSections = !IsDarwin;<br>
> +    HasDwarfPubSections = !IsDarwin && !IsPS4;<br>
>    else<br>
>      HasDwarfPubSections = DwarfPubSections == Enable;<br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div></blockquote></div><br></div></div>