<div dir="ltr"><br><br><div class="gmail_quote">On Tue, Mar 3, 2015 at 2:43 PM Frédéric Riss <<a href="mailto:friss@apple.com">friss@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On Mar 3, 2015, at 11:57 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
><br>
> Looks good in theory.<br>
<br>
Is that a LGTM, or do you wan me to respin the patch to you?<br>
<br></blockquote><div><br></div><div>It's fine for me, I just didn't want to explicitly LGTM a patch that doesn't build ;)</div><div><br></div><div>Feel free to commit when you'd like.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> I'd probably rename the emitDIE and emitAbbrevs to be emitDwarfDIE etc as part of the migration.<br>
<br>
Sure.<br>
<br>
Fred<br>
<br>
> -eric<br>
><br>
><br>
> <a href="http://reviews.llvm.org/D8024" target="_blank">http://reviews.llvm.org/D8024</a><br>
><br>
> EMAIL PREFERENCES<br>
>  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
><br>
><br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>