<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 3, 2015, at 2:58 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote">On Tue, Mar 3, 2015 at 2:43 PM Frédéric Riss <<a href="mailto:friss@apple.com" class="">friss@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
> On Mar 3, 2015, at 11:57 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:<br class="">
><br class="">
> Looks good in theory.<br class="">
<br class="">
Is that a LGTM, or do you wan me to respin the patch to you?<br class="">
<br class=""></blockquote><div class=""><br class=""></div><div class="">It's fine for me, I just didn't want to explicitly LGTM a patch that doesn't build ;)</div></div></div></div></blockquote><div><br class=""></div><div>I knew I shouldn’t have said that!</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class="">Feel free to commit when you'd like.</div></div></div></div></blockquote><div><br class=""></div><div>Thanks.</div><div><br class=""></div>Fred</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class="">-eric</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> I'd probably rename the emitDIE and emitAbbrevs to be emitDwarfDIE etc as part of the migration.<br class="">
<br class="">
Sure.<br class="">
<br class="">
Fred<br class="">
<br class="">
> -eric<br class="">
><br class="">
><br class="">
> <a href="http://reviews.llvm.org/D8024" target="_blank" class="">http://reviews.llvm.org/D8024</a><br class="">
><br class="">
> EMAIL PREFERENCES<br class="">
> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="">http://reviews.llvm.org/<u class=""></u>settings/panel/<u class=""></u>emailpreferences/</a><br class="">
><br class="">
><br class="">
<br class="">
<br class="">
______________________________<u class=""></u>_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>