<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Mar 3, 2015 at 5:16 AM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankar.kalpathi.easwaran@gmail.com" target="_blank">shankar.kalpathi.easwaran@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Other than the above mentioned comments code LGTM<br>
<br>
<br>
================<br>
Comment at: include/lld/Core/DefinedAtom.h:239<br>
@@ +238,3 @@<br>
+  ///<br>
+  /// Merge::mergeByLargestSection is defined in terms of section size<br>
+  /// and not in terms of atom size, so we need this function separate<br>
----------------<br>
Why are we mentioning the purpose if this function here. We could drop this comment.<br></blockquote><div><br></div><div>It helps reader understand not only "what" this function does but also "why" we have this here. That's a useful comment.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
================<br>
Comment at: lib/ReaderWriter/Native/ReaderNative.cpp:49<br>
@@ -51,1 +48,3 @@<br>
+  uint64_t size() const override { return _ivarData->contentSize; }<br>
+  uint64_t sectionSize() const override { return _ivarData->sectionSize; }<br>
<br>
----------------<br>
Can you add a new line before this function<br>
<div><div><br>
<a href="http://reviews.llvm.org/D7966" target="_blank">http://reviews.llvm.org/D7966</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div>