<div dir="ltr">Thanks both Quentin and Matthias.<div><br></div><div>Two completely meta points:</div><div><br></div><div>1) It'd be useful to mention this in a commit that obviously has no test case. Saves a round trip checking whether it just was accidentally left off the commit.</div><div><br></div><div>2) This makes me want to encourage thinking about ways to unittest components of CodeGen in the future. Historically we haven't looked at that, but if we need to support and debug out-of-tree targets with interesting properties like this it may became important to grow that ability. Its an important use case for these libraries to work even with wildly different targets, and important that folks can check that they're handling edge cases without access to all the weird targets in the world. =]</div><div><br></div><div>Anyways, thanks for explaining.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 3, 2015 at 5:29 PM, Quentin Colombet <span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">With the in-tree target this not exposed.<div><br></div><div>Arguably we could create a fake target with such problem, but I do not think this is worth the complexity.</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Q.</div></font></span><div> <br><div><blockquote type="cite"><span class=""><div>On Mar 3, 2015, at 5:21 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div><br></span><div><div><div class="h5"><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote"><br>On Tue, Mar 3, 2015 at 4:43 PM, Matthias Braun<span> </span><span dir="ltr"><<a href="mailto:matze@braunis.de" target="_blank">matze@braunis.de</a>></span><span> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden">Author: matze<br>Date: Tue Mar  3 18:43:50 2015<br>New Revision: 231186<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=231186&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231186&view=rev</a><br>Log:<br>RegisterCoalescer: Gracefully continue if subrange merging fails.<br><br>There is a known bug where the register coalescer fails to merge<br>subranges when multiple ranges end up in the "overflow" bit 32 of the<br>lanemasks. A proper fix for this is complicated so for now this is a<br>workaround which lets the register coalescer drop the subregister<br>liveness information (we just loose some precision by that) and<br>continue.<br><br>Modified:<br>   <span> </span>llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp</div></blockquote></div><br>No test case? This seems like something really important to cover...</div></div></div></div><span class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="mailto:llvm-commits@cs.uiuc.edu" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">llvm-commits@cs.uiuc.edu</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></span></div></blockquote></div><br></div></div></blockquote></div><br></div>