<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 3, 2015 at 1:45 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: dblaikie<br>
Date: Tue Mar  3 15:45:54 2015<br>
New Revision: 231142<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=231142&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=231142&view=rev</a><br>
Log:<br>
CFG::SuccessorIterator: Remove explicit copy assignment, as the default is fine<br>
<br>
There's no reason to disallow assigning an iterator from one range to an<br>
iterator that previously iterated over a disjoint range. This then<br>
follows the Rule of Zero, allowing implicit copy construction to be used<br>
without hitting the case that's deprecated in C++11.<br></blockquote><div><br>Missed that the 'Term' member was const. Unconstified in r231146<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/IR/CFG.h<br>
<br>
Modified: llvm/trunk/include/llvm/IR/CFG.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/CFG.h?rev=231142&r1=231141&r2=231142&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/CFG.h?rev=231142&r1=231141&r2=231142&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/IR/CFG.h (original)<br>
+++ llvm/trunk/include/llvm/IR/CFG.h Tue Mar  3 15:45:54 2015<br>
@@ -167,12 +167,6 @@ public:<br>
       idx = 0;<br>
   }<br>
<br>
-  inline const Self &operator=(const Self &I) {<br>
-    assert(Term == I.Term &&"Cannot assign iterators to two different blocks!");<br>
-    idx = I.idx;<br>
-    return *this;<br>
-  }<br>
-<br>
   /// getSuccessorIndex - This is used to interface between code that wants to<br>
   /// operate on terminator instructions directly.<br>
   unsigned getSuccessorIndex() const { return idx; }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>