<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 7:24 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Mon Mar  2 09:24:36 2015<br>
New Revision: 230965<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230965&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230965&view=rev</a><br>
Log:<br>
SLPVectorizer: Rewrite ArrayRef slice compare to be more idiomatic.<br>
<br>
NFC intended.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=230965&r1=230964&r2=230965&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=230965&r1=230964&r2=230965&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Mon Mar  2 09:24:36 2015<br>
@@ -3178,15 +3178,11 @@ private:<br>
 /// the WeakVH array.<br>
 /// Vectorization of part of the VL array may cause later values in the VL array<br>
 /// to become invalid. We track when this has happened in the WeakVH array.<br>
-static bool hasValueBeenRAUWed(ArrayRef<Value *> &VL,<br>
-                               SmallVectorImpl<WeakVH> &VH,<br>
-                               unsigned SliceBegin,<br>
-                               unsigned SliceSize) {<br>
-  for (unsigned i = SliceBegin; i < SliceBegin + SliceSize; ++i)<br>
-    if (VH[i] != VL[i])<br>
-      return true;<br>
-<br>
-  return false;<br>
+static bool hasValueBeenRAUWed(ArrayRef<Value *> VL, ArrayRef<WeakVH> VH,<br>
+                               unsigned SliceBegin, unsigned SliceSize) {<br>
+  VL = VL.slice(SliceBegin, SliceSize);<br>
+  VH = VH.slice(SliceBegin, SliceSize);<br>
+  return !std::equal(VL.begin(), VL.end(), VH.begin());<br></blockquote><div><br>Can we not just "return VL == VH;" here?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 }<br>
<br>
 bool SLPVectorizer::vectorizeStoreChain(ArrayRef<Value *> Chain,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>