<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 3:07 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: include/llvm/Analysis/AliasAnalysis.h:155-156<br>
@@ +154,4 @@<br>
+      return getLocation(I);<br>
+    else<br>
+      llvm_unreachable("unsupported memory instruction");<br>
+  }<br>
----------------<br>
No need for else here.</blockquote><div><br></div><div>Will fix </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br></blockquote><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
================<br>
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:1-2<br>
@@ +1,3 @@<br>
+//===- MemorySSA.h - Build Memory SSA ----------------------------*- C++<br>
+//-*-===//<br>
+//<br>
----------------<br>
This looks strange, can you make it look like the other files?<br>
<br></blockquote><div><br></div><div>Yeah, no idea what happened here.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
================<br>
Comment at: lib/Transforms/Utils/MemorySSA.cpp:1<br>
@@ +1,2 @@<br>
+<br>
+//===- MemorySSA.cpp - Memory SSA Builder----------------------------------===//<br>
----------------<br>
No need for this whitespace.<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D7864" target="_blank">http://reviews.llvm.org/D7864</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div>