<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">There will be other, non-Linux-y things going into the PS4 TLOF later.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Currently, no non-Linux ELF targets use DTPOFF for this. I can easily believe that's a bug that nobody has noticed, but I have no way to test/prove that.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">If you think that behavioral change will be correct, I'm happy with moving the method specialization up into TargetLoweringObjectFileELF.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:echristo@gmail.com]
<br>
<b>Sent:</b> Monday, March 02, 2015 9:53 AM<br>
<b>To:</b> Robinson, Paul; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm] r230979 - [PS4] Correct relocation for DWARF TLS references.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Can you revert and/or explain this patch a bit more? Can you not just use the generic linux lowering since you've effectively just copied it exactly and did a s/X86LInux/PS4 on the code?<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I'm perfectly happy even doing a s/X86Linux/X86ELF if it'll make you happy, but not the code duplication.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">-eric<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Mon, Mar 2, 2015 at 9:49 AM Paul Robinson <<a href="mailto:paul_robinson@playstation.sony.com">paul_robinson@playstation.sony.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: probinson<br>
Date: Mon Mar 2 11:44:52 2015<br>
New Revision: 230979<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230979&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=230979&view=rev</a><br>
Log:<br>
[PS4] Correct relocation for DWARF TLS references.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86TargetMachine.cpp<br>
llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp<br>
llvm/trunk/lib/Target/X86/X86TargetObjectFile.h<br>
llvm/trunk/test/DebugInfo/X86/tls.ll<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.cpp?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetMachine.cpp Mon Mar 2 11:44:52 2015<br>
@@ -37,6 +37,8 @@ static std::unique_ptr<TargetLoweringObj<br>
return make_unique<TargetLoweringObjectFileMachO>();<br>
}<br>
<br>
+ if (TT.isPS4CPU())<br>
+ return make_unique<PS4TargetObjectFile>();<br>
if (TT.isOSLinux())<br>
return make_unique<X86LinuxTargetObjectFile>();<br>
if (TT.isOSBinFormatELF())<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp Mon Mar 2 11:44:52 2015<br>
@@ -74,6 +74,11 @@ X86LinuxTargetObjectFile::getDebugThread<br>
return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
}<br>
<br>
+const MCExpr *PS4TargetObjectFile::getDebugThreadLocalSymbol(<br>
+ const MCSymbol *Sym) const {<br>
+ return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
+}<br>
+<br>
const MCExpr *X86WindowsTargetObjectFile::getExecutableRelativeSymbol(<br>
const ConstantExpr *CE, Mangler &Mang, const TargetMachine &TM) const {<br>
// We are looking for the difference of two symbols, need a subtraction<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetObjectFile.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.h?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.h?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetObjectFile.h (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetObjectFile.h Mon Mar 2 11:44:52 2015<br>
@@ -47,6 +47,12 @@ namespace llvm {<br>
const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const override;<br>
};<br>
<br>
+ /// \brief This TLOF implementation is used for PS4.<br>
+ class PS4TargetObjectFile : public TargetLoweringObjectFileELF {<br>
+ /// \brief Describe a TLS variable address within debug info.<br>
+ const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const override;<br>
+ };<br>
+<br>
/// \brief This implementation is used for Windows targets on x86 and x86-64.<br>
class X86WindowsTargetObjectFile : public TargetLoweringObjectFileCOFF {<br>
const MCExpr *<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/tls.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/tls.ll?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/tls.ll?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/X86/tls.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/tls.ll Mon Mar 2 11:44:52 2015<br>
@@ -7,6 +7,9 @@<br>
; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-unknown-linux-gnu -split-dwarf=Enable \<br>
; RUN: | FileCheck --check-prefix=CHECK --check-prefix=FISSION %s<br>
<br>
+; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-scei-ps4 \<br>
+; RUN: | FileCheck --check-prefix=CHECK --check-prefix=SINGLE --check-prefix=SINGLE-64 %s<br>
+<br>
; FIXME: add relocation and DWARF expression support to llvm-dwarfdump & use<br>
; that here instead of raw assembly printing<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>