<div dir="ltr"><br><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 10:10 AM Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">There will be other, non-Linux-y things going into the PS4 TLOF later.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> </span></p></div></div></blockquote><div>Let's burn that bridge when we come to it then.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Currently, no non-Linux ELF targets use DTPOFF for this. I can easily believe that's a bug that nobody has noticed, but I have no way to test/prove that.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">If you think that behavioral change will be correct, I'm happy with moving the method specialization up into TargetLoweringObjectFileELF.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"></span></p></div></div></blockquote><div><br></div><div>It will be correct for X86, but not necessarily aarch64 I think.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="msg-f:1494556135057753137__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]
<br>
<b>Sent:</b> Monday, March 02, 2015 9:53 AM<br>
<b>To:</b> Robinson, Paul; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [llvm] r230979 - [PS4] Correct relocation for DWARF TLS references.<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Can you revert and/or explain this patch a bit more? Can you not just use the generic linux lowering since you've effectively just copied it exactly and did a s/X86LInux/PS4 on the code?<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I'm perfectly happy even doing a s/X86Linux/X86ELF if it'll make you happy, but not the code duplication.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">-eric<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Mar 2, 2015 at 9:49 AM Paul Robinson <<a href="mailto:paul_robinson@playstation.sony.com" target="_blank">paul_robinson@playstation.sony.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: probinson<br>
Date: Mon Mar 2 11:44:52 2015<br>
New Revision: 230979<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230979&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=230979&view=rev</a><br>
Log:<br>
[PS4] Correct relocation for DWARF TLS references.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86TargetMachine.cpp<br>
llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp<br>
llvm/trunk/lib/Target/X86/X86TargetObjectFile.h<br>
llvm/trunk/test/DebugInfo/X86/tls.ll<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.cpp?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetMachine.cpp Mon Mar 2 11:44:52 2015<br>
@@ -37,6 +37,8 @@ static std::unique_ptr<TargetLoweringObj<br>
return make_unique<TargetLoweringObjectFileMachO>();<br>
}<br>
<br>
+ if (TT.isPS4CPU())<br>
+ return make_unique<PS4TargetObjectFile>();<br>
if (TT.isOSLinux())<br>
return make_unique<X86LinuxTargetObjectFile>();<br>
if (TT.isOSBinFormatELF())<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp Mon Mar 2 11:44:52 2015<br>
@@ -74,6 +74,11 @@ X86LinuxTargetObjectFile::getDebugThread<br>
return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
}<br>
<br>
+const MCExpr *PS4TargetObjectFile::getDebugThreadLocalSymbol(<br>
+ const MCSymbol *Sym) const {<br>
+ return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
+}<br>
+<br>
const MCExpr *X86WindowsTargetObjectFile::getExecutableRelativeSymbol(<br>
const ConstantExpr *CE, Mangler &Mang, const TargetMachine &TM) const {<br>
// We are looking for the difference of two symbols, need a subtraction<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86TargetObjectFile.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.h?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.h?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86TargetObjectFile.h (original)<br>
+++ llvm/trunk/lib/Target/X86/X86TargetObjectFile.h Mon Mar 2 11:44:52 2015<br>
@@ -47,6 +47,12 @@ namespace llvm {<br>
const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const override;<br>
};<br>
<br>
+ /// \brief This TLOF implementation is used for PS4.<br>
+ class PS4TargetObjectFile : public TargetLoweringObjectFileELF {<br>
+ /// \brief Describe a TLS variable address within debug info.<br>
+ const MCExpr *getDebugThreadLocalSymbol(const MCSymbol *Sym) const override;<br>
+ };<br>
+<br>
/// \brief This implementation is used for Windows targets on x86 and x86-64.<br>
class X86WindowsTargetObjectFile : public TargetLoweringObjectFileCOFF {<br>
const MCExpr *<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/tls.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/tls.ll?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/tls.ll?rev=230979&r1=230978&r2=230979&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/X86/tls.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/tls.ll Mon Mar 2 11:44:52 2015<br>
@@ -7,6 +7,9 @@<br>
; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-unknown-linux-gnu -split-dwarf=Enable \<br>
; RUN: | FileCheck --check-prefix=CHECK --check-prefix=FISSION %s<br>
<br>
+; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-scei-ps4 \<br>
+; RUN: | FileCheck --check-prefix=CHECK --check-prefix=SINGLE --check-prefix=SINGLE-64 %s<br>
+<br>
; FIXME: add relocation and DWARF expression support to llvm-dwarfdump & use<br>
; that here instead of raw assembly printing<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
</div></div></div></blockquote></div></div>