<div dir="ltr">Can you revert and/or explain this patch a bit more? Can you not just use the generic linux lowering since you've effectively just copied it exactly and did a s/X86LInux/PS4 on the code?<br><div><br></div><div>I'm perfectly happy even doing a s/X86Linux/X86ELF if it'll make you happy, but not the code duplication.</div><div><br></div><div>Thanks.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote">On Mon, Mar 2, 2015 at 9:49 AM Paul Robinson <<a href="mailto:paul_robinson@playstation.sony.com">paul_robinson@playstation.sony.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br>
Date: Mon Mar  2 11:44:52 2015<br>
New Revision: 230979<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230979&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=230979&view=rev</a><br>
Log:<br>
[PS4] Correct relocation for DWARF TLS references.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/<u></u>X86TargetMachine.cpp<br>
    llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.cpp<br>
    llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.h<br>
    llvm/trunk/test/DebugInfo/X86/<u></u>tls.ll<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<u></u>X86TargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86TargetMachine.cpp?rev=<u></u>230979&r1=230978&r2=230979&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/X86/<u></u>X86TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/<u></u>X86TargetMachine.cpp Mon Mar  2 11:44:52 2015<br>
@@ -37,6 +37,8 @@ static std::unique_ptr<<u></u>TargetLoweringObj<br>
     return make_unique<<u></u>TargetLoweringObjectFileMachO><u></u>();<br>
   }<br>
<br>
+  if (TT.isPS4CPU())<br>
+    return make_unique<<u></u>PS4TargetObjectFile>();<br>
   if (TT.isOSLinux())<br>
     return make_unique<<u></u>X86LinuxTargetObjectFile>();<br>
   if (TT.isOSBinFormatELF())<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.cpp?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86TargetObjectFile.cpp?<u></u>rev=230979&r1=230978&r2=<u></u>230979&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.cpp Mon Mar  2 11:44:52 2015<br>
@@ -74,6 +74,11 @@ X86LinuxTargetObjectFile::<u></u>getDebugThread<br>
   return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
 }<br>
<br>
+const MCExpr *PS4TargetObjectFile::<u></u>getDebugThreadLocalSymbol(<br>
+    const MCSymbol *Sym) const {<br>
+  return MCSymbolRefExpr::Create(Sym, MCSymbolRefExpr::VK_DTPOFF, getContext());<br>
+}<br>
+<br>
 const MCExpr *X86WindowsTargetObjectFile::<u></u>getExecutableRelativeSymbol(<br>
     const ConstantExpr *CE, Mangler &Mang, const TargetMachine &TM) const {<br>
   // We are looking for the difference of two symbols, need a subtraction<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetObjectFile.h?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86TargetObjectFile.h?rev=<u></u>230979&r1=230978&r2=230979&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.h (original)<br>
+++ llvm/trunk/lib/Target/X86/<u></u>X86TargetObjectFile.h Mon Mar  2 11:44:52 2015<br>
@@ -47,6 +47,12 @@ namespace llvm {<br>
     const MCExpr *getDebugThreadLocalSymbol(<u></u>const MCSymbol *Sym) const override;<br>
   };<br>
<br>
+  /// \brief This TLOF implementation is used for PS4.<br>
+  class PS4TargetObjectFile : public TargetLoweringObjectFileELF {<br>
+    /// \brief Describe a TLS variable address within debug info.<br>
+    const MCExpr *getDebugThreadLocalSymbol(<u></u>const MCSymbol *Sym) const override;<br>
+  };<br>
+<br>
   /// \brief This implementation is used for Windows targets on x86 and x86-64.<br>
   class X86WindowsTargetObjectFile : public TargetLoweringObjectFileCOFF {<br>
     const MCExpr *<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/<u></u>tls.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/tls.ll?rev=230979&r1=230978&r2=230979&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>DebugInfo/X86/tls.ll?rev=<u></u>230979&r1=230978&r2=230979&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/DebugInfo/X86/<u></u>tls.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/<u></u>tls.ll Mon Mar  2 11:44:52 2015<br>
@@ -7,6 +7,9 @@<br>
 ; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-unknown-linux-<u></u>gnu -split-dwarf=Enable \<br>
 ; RUN:   | FileCheck --check-prefix=CHECK --check-prefix=FISSION %s<br>
<br>
+; RUN: llc %s -o - -filetype=asm -O0 -mtriple=x86_64-scei-ps4 \<br>
+; RUN:   | FileCheck --check-prefix=CHECK --check-prefix=SINGLE --check-prefix=SINGLE-64 %s<br>
+<br>
 ; FIXME: add relocation and DWARF expression support to llvm-dwarfdump & use<br>
 ; that here instead of raw assembly printing<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>