<p dir="ltr"><br>
On Mar 1, 2015 6:52 AM, "Bill Schmidt" <<a href="mailto:wschmidt@linux.vnet.ibm.com">wschmidt@linux.vnet.ibm.com</a>> wrote:<br>
><br>
> On Fri, 2015-02-27 at 14:50 -0800, David Blaikie wrote:<br>
> ><br>
> ><br>
> > On Fri, Feb 27, 2015 at 2:31 PM, Bill Schmidt<br>
> > <<a href="mailto:wschmidt@linux.vnet.ibm.com">wschmidt@linux.vnet.ibm.com</a>> wrote:<br>
> > Author: wschmidt<br>
> > Date: Fri Feb 27 16:31:14 2015<br>
> > New Revision: 230803<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230803&view=rev">http://llvm.org/viewvc/llvm-project?rev=230803&view=rev</a><br>
> > Log:<br>
> > Revert test case until it can be fixed<br>
> ><br>
> > Usually if a test is going to be reverted, so should the change (just<br>
> > revert the whole commit, fix it, recommit) - rather than leaving the<br>
> > functionality untested in-tree.<br>
><br>
> Yes, I'm aware of that, but in this case it was clear that I had just<br>
> effed the test case due to your changes and wanted to quickly shut up<br>
> the build bots</p>
<p dir="ltr">Reverting still does a pretty good job of during up the buildbots and is about as timely to execute. Helps maintain the 'code is tested' line and avoid reviewers having to check that the test for resubmitted at some point (did it? A follow up email to this review mentioning the revision where this was resubmitted would be helpful)</p>
<p dir="ltr">> till I could get through a 10-minute fix/test cycle. </p>
<p dir="ltr">What it is it in your cycle that takes ten minutes? If you are only modifying one test file then you can be fairly sure it won't affect other tests, so you can just run that test in isolation. Lit can take the project relative test path (or parent directory path) to run individual tests. Can be quite handy to iterate faster rather than waiting for complete test cycles.</p>
<p dir="ltr">> If<br>
> it had been a more pervasive issue I would of course have reverted the<br>
> fix as well.<br>
><br>
> Bill<br>
> ><br>
> > In this case it looks like you just need to update for my recent<br>
> > explicit type change for load and gep.<br>
> ><br>
> ><br>
> > Removed:<br>
> > llvm/trunk/test/CodeGen/PowerPC/pr22711.ll<br>
> ><br>
> > Removed: llvm/trunk/test/CodeGen/PowerPC/pr22711.ll<br>
> > URL:<br>
> > <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/pr22711.ll?rev=230802&view=auto">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/pr22711.ll?rev=230802&view=auto</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/CodeGen/PowerPC/pr22711.ll (original)<br>
> > +++ llvm/trunk/test/CodeGen/PowerPC/pr22711.ll (removed)<br>
> > @@ -1,65 +0,0 @@<br>
> > -; Verify that the .toc section is aligned on an 8-byte<br>
> > boundary.<br>
> > -<br>
> > -; RUN: llc < %s -mtriple=powerpc64-unknown-linux-gnu<br>
> > -mcpu=pwr8 -filetype=obj -o - | llvm-readobj --sections |<br>
> > FileCheck %s<br>
> > -<br>
> > -define void @test(i32* %a) {<br>
> > -entry:<br>
> > - %a.addr = alloca i32*, align 8<br>
> > - store i32* %a, i32** %a.addr, align 8<br>
> > - %0 = load i32** %a.addr, align 8<br>
> ><br>
> > %0 = load i32*, i32** %a.addr, align 8<br>
> ><br>
> > (& similar changes for all the other loads)<br>
> ><br>
> > - %incdec.ptr = getelementptr inbounds i32* %0, i32 1<br>
> ><br>
> > %incdec.ptr = getelementptr inbounds i32, i32* %0, i32 1<br>
> ><br>
> > - store i32* %incdec.ptr, i32** %a.addr, align 8<br>
> > - %1 = load i32* %0, align 4<br>
> > - switch i32 %1, label %sw.epilog [<br>
> > - i32 17, label %<a href="http://sw.bb">sw.bb</a><br>
> > - i32 13, label %sw.bb1<br>
> > - i32 11, label %sw.bb2<br>
> > - i32 7, label %sw.bb3<br>
> > - i32 5, label %sw.bb4<br>
> > - i32 3, label %sw.bb5<br>
> > - i32 2, label %sw.bb6<br>
> > - ]<br>
> > -<br>
> > -<a href="http://sw.bb">sw.bb</a>: ; preds = %<br>
> > entry<br>
> > - %2 = load i32** %a.addr, align 8<br>
> > - store i32 2, i32* %2, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb1: ; preds = %<br>
> > entry<br>
> > - %3 = load i32** %a.addr, align 8<br>
> > - store i32 3, i32* %3, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb2: ; preds = %<br>
> > entry<br>
> > - %4 = load i32** %a.addr, align 8<br>
> > - store i32 5, i32* %4, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb3: ; preds = %<br>
> > entry<br>
> > - %5 = load i32** %a.addr, align 8<br>
> > - store i32 7, i32* %5, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb4: ; preds = %<br>
> > entry<br>
> > - %6 = load i32** %a.addr, align 8<br>
> > - store i32 11, i32* %6, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb5: ; preds = %<br>
> > entry<br>
> > - %7 = load i32** %a.addr, align 8<br>
> > - store i32 13, i32* %7, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.bb6: ; preds = %<br>
> > entry<br>
> > - %8 = load i32** %a.addr, align 8<br>
> > - store i32 17, i32* %8, align 4<br>
> > - br label %sw.epilog<br>
> > -<br>
> > -sw.epilog: ; preds = %<br>
> > entry, %sw.bb6, %sw.bb5, %sw.bb4, %sw.bb3, %sw.bb2, %sw.bb1, %<br>
> > <a href="http://sw.bb">sw.bb</a><br>
> > - ret void<br>
> > -}<br>
> > -<br>
> > -; CHECK: Name: .toc<br>
> > -; CHECK: AddressAlignment: 8<br>
> > -; CHECK: Name: .rela.toc<br>
> > -<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
> ><br>
> ><br>
><br>
><br>
</p>