<p dir="ltr"><br>
On Feb 27, 2015 7:52 AM, "Mehdi AMINI" <<a href="mailto:mehdi.amini@apple.com">mehdi.amini@apple.com</a>> wrote:<br>
><br>
> ================<br>
> Comment at: lib/IR/PassRegistry.cpp:52<br>
> @@ +51,3 @@<br>
> +  if (needMutex)<br>
> +    Lock.unlock_shared();<br>
> +  return PI;<br>
> ----------------<br>
> It is unfortunate to lose RAII, is there a good reason why SmartScopedReader cannot take an extra parameter to be constructed without locking? (like std::unique_lock())</p>
<p dir="ltr">(Agreed, and I provided a patch in my last reply that keeps RAII)</p>
<p dir="ltr">><br>
> <a href="http://reviews.llvm.org/D7787">http://reviews.llvm.org/D7787</a><br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>