<div dir="ltr">If it should not happen, why not just assert?<div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 25, 2015 at 10:03 AM, Matthias Braun <span dir="ltr"><<a href="mailto:matze@braunis.de" target="_blank">matze@braunis.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: matze<br>
Date: Wed Feb 25 12:03:50 2015<br>
New Revision: 230517<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230517&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230517&view=rev</a><br>
Log:<br>
AArch64: Add debug message for large shift constants.<br>
<br>
As requested in code review.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp?rev=230517&r1=230516&r2=230517&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp?rev=230517&r1=230516&r2=230517&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp (original)<br>
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp Wed Feb 25 12:03:50 2015<br>
@@ -1399,8 +1399,11 @@ static bool isBitfieldExtractOpFromAnd(S<br>
<br>
   // Bail out on large immediates. This happens when no proper<br>
   // combining/constant folding was performed.<br>
-  if (!BiggerPattern && (Srl_imm <= 0 || Srl_imm >= VT.getSizeInBits()))<br>
+  if (!BiggerPattern && (Srl_imm <= 0 || Srl_imm >= VT.getSizeInBits())) {<br>
+    DEBUG((dbgs() << N<br>
+           << ": Found large shift immediate, this should not happen\n"));<br>
     return false;<br>
+  }<br>
<br>
   LSB = Srl_imm;<br>
   MSB = Srl_imm + (VT == MVT::i32 ? countTrailingOnes<uint32_t>(And_imm)<br>
@@ -1506,8 +1509,11 @@ static bool isBitfieldExtractOpFromShr(S<br>
<br>
   // Missing combines/constant folding may have left us with strange<br>
   // constants.<br>
-  if (Shl_imm >= VT.getSizeInBits())<br>
+  if (Shl_imm >= VT.getSizeInBits()) {<br>
+    DEBUG((dbgs() << N<br>
+           << ": Found large shift immediate, this should not happen\n"));<br>
     return false;<br>
+  }<br>
<br>
   uint64_t Srl_imm = 0;<br>
   if (!isIntImmediate(N->getOperand(1), Srl_imm))<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>