<div dir="ltr">Can we add llvm::support::endian::read{le,be}{16,32,64}(void *) and llvm::support::endian::write{le,be}{16,32,64}(void *, uint64_t)?<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 26, 2015 at 4:04 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Thu, Feb 26, 2015 at 3:58 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64<br>
@@ +63,3 @@<br>
<span>+      result |<br>
+      (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t *>(location);<br>
+}<br>
</span>----------------<br>
<span>davide wrote:<br>
> ruiu wrote:<br>
> > Not sure if clang-format formatted like this, but I think there should be no space around "*".<br>
> Ditto. No, it did not, I tried to be consistent to what was already there.<br>
</span>Can you just use endian::read and endian::write functions?</blockquote><div><br></div></span><div>Is</div><div><br></div><div>  llvm::support::endian::write<uint64_t, support::little, support::unaligned>(location)</div><div><br></div><div>better than</div><div><br></div><div>  (uint64_t)*reinterpret_cast<llvm::support::ulittle64_t *>(location)</div><div><br></div><div>?</div></div></div></div>
</blockquote></div><br></div></div>