<br><br>On Thursday, February 26, 2015, Reid Kleckner <<a href="mailto:reid@kleckner.net">reid@kleckner.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Thu Feb 26 15:34:11 2015<br>
New Revision: 230692<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230692&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230692&view=rev</a><br>
Log:<br>
Re-instate the pragma optimize hack for MSVC, but not clang-cl<br>
<br>
Reverts commit r230686 with define modifications.<br>
<br>
Modified:<br>
    llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp<br>
<br>
Modified: llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp?rev=230692&r1=230691&r2=230692&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp?rev=230692&r1=230691&r2=230692&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp Thu Feb 26 15:34:11 2015<br>
@@ -292,6 +292,10 @@ static void EncodeFixedValueType(MVT::Si<br>
   }<br>
 }<br>
<br>
+#if defined(_MSC_VER) && !defined(__clang__)<br>
+#pragma optimize("",off) // MSVC 2010 optimizer can't deal with this function.<br>
+#endif<br>
+</blockquote><div><br></div>Does the comment need updating? Surely this isn't for MSVC 2010 at this point.<br><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 static void EncodeFixedType(Record *R, std::vector<unsigned char> &ArgCodes,<br>
                             std::vector<unsigned char> &Sig) {<br>
<br>
@@ -377,6 +381,10 @@ static void EncodeFixedType(Record *R, s<br>
   EncodeFixedValueType(VT, Sig);<br>
 }<br>
<br>
+#if defined(_MSC_VER) && !defined(__clang__)<br>
+#pragma optimize("",on)<br>
+#endif<br>
+<br>
 /// ComputeFixedEncoding - If we can encode the type signature for this<br>
 /// intrinsic into 32 bits, return it.  If not, return ~0U.<br>
 static void ComputeFixedEncoding(const CodeGenIntrinsic &Int,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@cs.uiuc.edu')">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>