<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Feb 25, 2015 at 5:38 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 2015 Feb 25, at 16:00, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
><br>
> Author: echristo<br>
> Date: Wed Feb 25 18:00:35 2015<br>
> New Revision: 230585<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230585&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=230585&view=rev</a><br>
> Log:<br>
> Remove a FIXME.<br>
><br>
> Explanation: This function is in TargetLowering because it uses<br>
> RegClassForVT which would need to be moved to TargetRegisterInfo<br>
> and would necessitate moving isTypeLegal over as well - a massive<br>
> change that would just require TargetLowering having a TargetRegisterInfo<br>
> class member that it would use.<br>
<br>
Should this be in a doxygen comment in the header?<br>
<br></blockquote><div><br></div><div>Possibly not doxygen, but I can put it above the actual function?</div><div><br></div><div>Thoughts?</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> Modified:<br>
>    llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=230585&r1=230584&r2=230585&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86ISelLowering.cpp?rev=<u></u>230585&r1=230584&r2=230585&<u></u>view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp (original)<br>
> +++ llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp Wed Feb 25 18:00:35 2015<br>
> @@ -1930,7 +1930,6 @@ getPICJumpTableRelocBaseExpr(<u></u>const Machi<br>
>   return MCSymbolRefExpr::Create(MF-><u></u>getPICBaseSymbol(), Ctx);<br>
> }<br>
><br>
> -// FIXME: Why this routine is here? Move to RegInfo!<br>
> std::pair<const TargetRegisterClass *, uint8_t><br>
> X86TargetLowering::<u></u>findRepresentativeClass(const TargetRegisterInfo *TRI,<br>
>                                            MVT VT) const {<br>
><br>
><br>
> ______________________________<u></u>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div></div>