<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Feb 25, 2015 at 6:16 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On 2015 Feb 19, at 16:03, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
><br>
> Author: echristo<br>
> Date: Thu Feb 19 18:03:45 2015<br>
> New Revision: 229938<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229938&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=229938&view=rev</a><br>
> Log:<br>
> This needs to be a const variable so the two sides of the ternary<br>
> operator agree on type.<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/CodeGen/<u></u>AsmPrinter/<u></u>AsmPrinterInlineAsm.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/<u></u>AsmPrinter/<u></u>AsmPrinterInlineAsm.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp?rev=229938&r1=229937&r2=229938&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/<u></u>CodeGen/AsmPrinter/<u></u>AsmPrinterInlineAsm.cpp?rev=<u></u>229938&r1=229937&r2=229938&<u></u>view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- llvm/trunk/lib/CodeGen/<u></u>AsmPrinter/<u></u>AsmPrinterInlineAsm.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/<u></u>AsmPrinter/<u></u>AsmPrinterInlineAsm.cpp Thu Feb 19 18:03:45 2015<br>
> @@ -152,7 +152,8 @@ void AsmPrinter::EmitInlineAsm(<u></u>StringRef<br>
>   // and not have a MachineFunction to initialize the TargetInstrInfo from and<br>
>   // we only need MCInstrInfo for asm parsing.<br>
>   std::unique_ptr<<u></u>MCTargetAsmParser> TAP(TM.getTarget().<u></u>createMCAsmParser(<br>
> -      *STI, *Parser, MII ? *MII : *TM.getTarget().<u></u>createMCInstrInfo(),<br>
> +      *STI, *Parser, MII ? *MII : *static_cast<const MCInstrInfo *>(<br>
<br>
Can this just be a `const_cast<>`?<br>
<br></blockquote><div><br></div><div>I don't think so (at least I recall trying that first and getting a type error), that said, the code has changed anyhow to be cleaner/better :)</div><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> +                                      TM.getTarget().<u></u>createMCInstrInfo()),<br>
>       TM.Options.MCOptions));<br>
>   if (!TAP)<br>
>     report_fatal_error("Inline asm not supported by this streamer because"<br>
><br>
><br>
> ______________________________<u></u>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div></div>