<div dir="ltr">Why not? I'm not suggesting adding them to this particular file but to llvm::support. If it's part of the library, no reason to exclude big endian.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 26, 2015 at 4:55 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <div>Why big endian ?<div><div class="h5"><br>
      <br>
      On 2/26/2015 6:53 PM, Rui Ueyama wrote:<br>
    </div></div></div>
    <blockquote type="cite"><div><div class="h5">
      <pre>Can we add llvm::support::endian::read{le,be}{16,32,64}(void *)
and llvm::support::endian::write{le,be}{16,32,64}(void *, uint64_t)?

On Thu, Feb 26, 2015 at 4:04 PM, Rui Ueyama <a href="mailto:ruiu@google.com" target="_blank"><ruiu@google.com></a> wrote:

</pre>
      <blockquote type="cite">
        <pre>On Thu, Feb 26, 2015 at 3:58 PM, Sean Silva <a href="mailto:chisophugis@gmail.com" target="_blank"><chisophugis@gmail.com></a> wrote:

</pre>
        <blockquote type="cite">
          <pre>REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64
@@ +63,3 @@
+      result |
+      (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t
*>(location);
+}
----------------
davide wrote:
</pre>
          <blockquote type="cite">
            <pre>ruiu wrote:
</pre>
            <blockquote type="cite">
              <pre>Not sure if clang-format formatted like this, but I think there
</pre>
            </blockquote>
          </blockquote>
          <pre>should be no space around "*".
</pre>
          <blockquote type="cite">
            <pre>Ditto. No, it did not, I tried to be consistent to what was already
</pre>
          </blockquote>
          <pre>there.
Can you just use endian::read and endian::write functions?
</pre>
        </blockquote>
        <pre>
Is

  llvm::support::endian::write<uint64_t, support::little,
support::unaligned>(location)

better than

  (uint64_t)*reinterpret_cast<llvm::support::ulittle64_t *>(location)

?

</pre>
      </blockquote>
      <pre></pre>
      <br>
      <fieldset></fieldset>
      <br>
      </div></div><span class=""><pre>_______________________________________________
llvm-commits mailing list
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
    </span></blockquote><span class="HOEnZb"><font color="#888888">
    <br>
    <br>
    <pre cols="72">-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
  </font></span></div>

</blockquote></div><br></div>