<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 25, 2015 at 12:19 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Wed Feb 25 14:19:23 2015<br>
New Revision: 230537<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230537&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230537&view=rev</a><br>
Log:<br>
[asan] restict no_asan_gen_globals.c test to 64-bit due to PR22682<br></blockquote><div><br>Awesome - thanks! Glad to have my build green again.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc<br>
    compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c<br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc?rev=230537&r1=230536&r2=230537&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc?rev=230537&r1=230536&r2=230537&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/Linux/odr-violation.cc Wed Feb 25 14:19:23 2015<br>
@@ -10,13 +10,13 @@<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=1 not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=0     %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED<br>
-// RUN:                                     not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
+// RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0                        not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
 //<br>
 // Same size: report a bug only if detect_odr_violation>=2.<br>
 // RUN: %clangxx_asan -DBUILD_SO=1 -fPIC -shared %s -o %t-ODR-SO.so -DSZ=100<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=1     %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
-// RUN:                                     not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
+// RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0                        not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
 // RUN: echo "odr_violation:foo::ZZZ" > %t.supp<br>
 // RUN: ASAN_OPTIONS=fast_unwind_on_malloc=0:detect_odr_violation=2:suppressions=%t.supp  not %run %t-ODR-EXE 2>&1 | FileCheck %s<br>
 // RUN: echo "odr_violation:foo::G" > %t.supp<br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c?rev=230537&r1=230536&r2=230537&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c?rev=230537&r1=230536&r2=230537&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/no_asan_gen_globals.c Wed Feb 25 14:19:23 2015<br>
@@ -1,5 +1,7 @@<br>
 // FIXME: <a href="https://code.google.com/p/address-sanitizer/issues/detail?id=316" target="_blank">https://code.google.com/p/address-sanitizer/issues/detail?id=316</a><br>
 // XFAIL: android<br>
+// FIXME: <a href="http://llvm.org/bugs/show_bug.cgi?id=22682" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=22682</a><br>
+// REQUIRES: asan-64-bits<br>
 //<br>
 // Make sure __asan_gen_* strings do not end up in the symbol table.<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>