<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 24, 2015 at 4:27 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5"><br>
> On 2015-Feb-24, at 16:27, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
> Change to the more common VBR default of 6 bits rather than 8.<br>
><br>
><br>
> <a href="http://reviews.llvm.org/D7736" target="_blank">http://reviews.llvm.org/D7736</a><br>
><br>
> Files:<br>
>  include/llvm/Bitcode/LLVMBitCodes.h<br>
>  include/llvm/IR/Instructions.h<br>
>  lib/Bitcode/Reader/BitcodeReader.cpp<br>
>  lib/Bitcode/Writer/BitcodeWriter.cpp<br>
>  test/Bitcode/function-encoding-rel-operands.ll<br>
>  tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp<br>
><br>
> EMAIL PREFERENCES<br>
>  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div>> <D7736.20637.patch><br>
<br>
Afterthought -- can you confirm whether GEPs already covered well<br>
for bitcode upgrading (both inbounds and not)?  If not, you should<br>
probably add testcases that 3.5 GEPs can be read going forward.<br></blockquote><div><br>Yep, adding "llvm_unreachable" after <br>     case bitc::FUNC_CODE_INST_INBOUNDS_GEP_OLD:<div>    case bitc::FUNC_CODE_INST_GEP_OLD:<br><br>(before the main block under INST_GEP) causes failures in test/Bitcode/{constantTest,memInstructions}.3.2.ll, looking at those ll files they seem to cover a myriad of geps, so I'm OK using that as coverage here.</div><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>