<div dir="ltr">LGTM<div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 22, 2015 at 9:16 PM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Commments inline.<br>
<span><br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:62<br>
@@ +61,3 @@<br>
</span><span>+  int64_t result = (uint64_t)((S + A) - P);<br>
+  *reinterpret_cast<llvm::support::ulittle64_t *>(location) =<br>
+      result |<br>
</span>----------------<br>
<span>ruiu wrote:<br>
> Can you add using llvm::support::ulittle64_t at beginning of the file and use that here?<br>
</span>This follows the style of the rest of the file, wouldn't be better commit the patch as is and change the style for the whole file in a subsequent pass?<br></blockquote><div><br></div><div>Maybe. If we do that these three lines can fit in one line.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
================<br>
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64<br>
@@ +63,3 @@<br>
</span><span>+      result |<br>
+      (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t *>(location);<br>
+}<br>
</span>----------------<br>
<span>ruiu wrote:<br>
> Not sure if clang-format formatted like this, but I think there should be no space around "*".<br>
</span>Ditto. No, it did not, I tried to be consistent to what was already there.<br></blockquote><div><br></div><div>OK. But this doesn't follow the style guide, I believe. It may be better to fix them in a different patch.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><br>
<a href="http://reviews.llvm.org/D7820" target="_blank">http://reviews.llvm.org/D7820</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div>