<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 23, 2015 at 12:19 PM, Andrew Kaylor <span dir="ltr"><<a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: akaylor<br>
Date: Mon Feb 23 14:19:15 2015<br>
New Revision: 230252<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=230252&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=230252&view=rev</a><br>
Log:<br>
Attempting to fix WinEHCatchDirector destructor related build failures.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/WinEHPrepare.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/WinEHPrepare.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/WinEHPrepare.cpp?rev=230252&r1=230251&r2=230252&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/WinEHPrepare.cpp?rev=230252&r1=230251&r2=230252&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/WinEHPrepare.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/WinEHPrepare.cpp Mon Feb 23 14:19:15 2015<br>
@@ -96,6 +96,7 @@ public:<br>
         Materializer(CatchFn, VarInfo),<br>
         SelectorIDType(Type::getInt32Ty(LPI->getContext())),<br>
         Int8PtrType(Type::getInt8PtrTy(LPI->getContext())) {}<br>
+  virtual ~WinEHCatchDirector() = default;<br></blockquote><div><br>Why would this do anything if the base class already has a virtual dtor? (& if it stays this way, it should be marked override, not virtual, since it's already virtual in the base class -Winconsistent-missing-override will fire on this code as-is, I think)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   CloningAction handleInstruction(ValueToValueMapTy &VMap,<br>
                                   const Instruction *Inst,<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>