<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi <div class=""><br class=""></div><div class="">I have a question with this patch.</div><div class=""><br class=""></div><div class="">Consider a DAG which looks like</div><div class="">v4i8 concat_vectors( v2i8 BUILD_VECTOR(i16 , i16), v2i8 BUILD_VECTOR(i16, i16)). Consider that v2i8, v4i8 and i16 are legal types but i8 is not.</div><div class=""><br class=""></div><div class="">Previously, we would have picked the minimum type from</div><div class=""><div class="">EVT SclTy0 = N0.getOperand(0)->getValueType(0); </div></div><div class="">EVT SclTy1 = N1.getOperand(0)->getValueType(0);</div><div class=""><span style="font-family: Menlo, Consolas, Monaco, monospace; font-size: 10px; line-height: 16px; white-space: pre-wrap; background-color: rgb(255, 170, 170);" class="">EVT MinTy = SclTy0.bitsLE(SclTy1) ? SclTy0 : SclTy1;</span></div><div class="">This would give us i16 as the MinType which is legal.</div><div class=""><br class=""></div><div class="">After the patch, this would pick </div><div class="">MinType =VT.getScalarType()</div><div class="">which would be i8 and this would be illegal on the target.</div><div class=""><br class=""></div><div class="">I believe this happens after TypeLegalization. Is the transformation correct?</div><div class=""><br class=""></div><div class="">Thanks</div><div class="">Aditya</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 22, 2015, at 10:20 AM, Simon Pilgrim <<a href="mailto:llvm-dev@redking.me.uk" class="">llvm-dev@redking.me.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Thanks Andrea<br class=""><br class=""><br class="">REPOSITORY<br class=""> rL LLVM<br class=""><br class=""><a href="http://reviews.llvm.org/D7816" class="">http://reviews.llvm.org/D7816</a><br class=""><br class="">EMAIL PREFERENCES<br class=""> http://reviews.llvm.org/settings/panel/emailpreferences/<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@cs.uiuc.edu<br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>