<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 16, 2015 at 5:53 AM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Mon Feb 16 07:53:00 2015<br>
New Revision: 229392<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229392&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=229392&view=rev</a><br>
Log:<br>
tsan: fix compiler warning<br>
<br>
mingw gcc complains:<br>
warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]<br>
       Printf("Failed to read options from '%s': error %d\n", value, err);<br></blockquote><div><br>Was the warning correct? Or could we be sure that ReadFileToBuffer would initialize 'err'?<br><br>Generally we should try not to unnecessarily initialize variables just to satisfy warnings because it hurts sanitizers (though I suppose that argument doesn't apply to the sanitizer libraries themselves - it still seems like a good principle to apply)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc?rev=229392&r1=229391&r2=229392&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc?rev=229392&r1=229391&r2=229392&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_flags.cc Mon Feb 16 07:53:00 2015<br>
@@ -54,7 +54,7 @@ class FlagHandlerInclude : public FlagHa<br>
   bool Parse(const char *value) final {<br>
     char *data;<br>
     uptr data_mapped_size;<br>
-    int err;<br>
+    int err = 0;<br>
     uptr len =<br>
       ReadFileToBuffer(value, &data, &data_mapped_size,<br>
                        Max(kMaxIncludeSize, GetPageSizeCached()), &err);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>