<div dir="ltr">Ah, yes. Warning it is.<div><br></div><div>Committing soon.</div><div><br></div><div> Filipe</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 17, 2015 at 5:05 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I guess I'd downgrade this to a warning or something. We can't really defend the user from all the broken compilers in the world. As much as I hate build spam, cmake already prints things when reconfiguring, so this shouldn't be painful.<div><div class="h5"><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 17, 2015 at 4:40 PM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:me@filcab.net" target="_blank">me@filcab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">ASTMatchers tests broke over the weekend due to a silent miscompile, as far as we could understand.<div><br></div><div>Could you run check-clang and have it work, before this commit?</div><div><br></div><div>When committing, I figured it was a small change, so there shouldn't be big problems, but after committing I figured there might be people who wouldn't be ready, and I hadn't given a heads up. I then figured I would wait and see if someone complained, either way.</div><div><br></div><div>If you want to, I can revert this patch, but this might prompt people to try to chase weird MSVC miscompilations. If we revert it we should probably make it so that llvm/clang compile and run tests on earlier revisions though, and actually support point-releases (and document which ones are supported), which doesn't seem feasible to me (we have enough “problems” supporting major releases, sometimes).</div><div><br></div><div>Let me know if you still want me to revert it, though.</div><span><font color="#888888"><div><br></div><div> Filipe</div></font></span><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 17, 2015 at 4:29 PM, Kaylor, Andrew <span dir="ltr"><<a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">This is a fairly painful change for me.<br>
<br>
I didn't really mind the idea of not being able to build with MSVC 2012 because it's three years old or so. MSVC 2013 Update 4, on the other hand, is more like 3 months old. Granted it's still readily available, but it hasn't made its way through the lab systems here yet and I suspect I'm not alone in experiencing this.<br>
<br>
I'm not sure what the issue is. This morning I could build just fine. Now this afternoon, I can't because CMake thinks my compiler is too old.<br>
<br>
What is the issue with ASTMatchers on earlier versions of MSVC? Is it something that was just exposed by a recent commit? I hadn't noticed a problem.<br>
<br>
-Andy<br>
<span><br>
<br>
-----Original Message-----<br>
From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Filipe Cabecinhas<br>
Sent: Tuesday, February 17, 2015 3:29 PM<br>
To: <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
Subject: [llvm] r229584 - We require MSVC 2013 Update 4 due to previous versions miscompiling ASTMatchers<br>
<br>
Author: filcab<br>
Date: Tue Feb 17 17:29:00 2015<br>
New Revision: 229584<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229584&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=229584&view=rev</a><br>
Log:<br>
We require MSVC 2013 Update 4 due to previous versions miscompiling ASTMatchers<br>
<br>
Previous versions of MSVC 2013 would miscompile ASTMatchers (and/or their tests). Bump up the requirement and make sure we know about the minor revision.<br>
<br>
Minimum required version found by Michael Edwards!<br>
<br>
Modified:<br>
llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=229584&r1=229583&r2=229584&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=229584&r1=229583&r2=229584&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)<br>
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Tue Feb 17 17:29:00<br>
</span>+++ 2015<br>
<div><div>@@ -41,8 +41,8 @@ int main() { return (float)x; }"<br>
set(CMAKE_REQUIRED_LIBRARIES ${OLD_CMAKE_REQUIRED_LIBRARIES})<br>
endif()<br>
elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")<br>
- if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18.0)<br>
- message(FATAL_ERROR "Host Visual Studio must be at least 2013 (MSVC 18.0)")<br>
+ if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18.0.31101)<br>
+ message(FATAL_ERROR "Host Visual Studio must be at least 2013<br>
+ Update 4 (MSVC 18.0.31101)")<br>
endif()<br>
endif()<br>
endif()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div></div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>