<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 13, 2015, at 7:35 AM, Tom Stellard <<a href="mailto:tom@stellard.net" class="">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Thu, Feb 12, 2015 at 06:15:52PM -0800, Matt Arsenault wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" class="">On Feb 6, 2015, at 10:53 AM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a>> wrote:<br class=""><br class=""><blockquote type="cite" class=""><br class="">On Jan 31, 2015, at 3:46 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Dec 12, 2014, at 2:54 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Dec 11, 2014, at 9:36 PM, Tom Stellard <<a href="mailto:tom@stellard.net" class="">tom@stellard.net</a><span class="Apple-converted-space"> </span><<a href="mailto:tom@stellard.net" class="">mailto:tom@stellard.net</a>>> wrote:<br class=""><br class="">On Thu, Dec 11, 2014 at 06:40:06PM -0500, Matt Arsenault wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On Dec 11, 2014, at 6:15 PM, Tom Stellard <<a href="mailto:tom@stellard.net" class="">tom@stellard.net</a><span class="Apple-converted-space"> </span><<a href="mailto:tom@stellard.net" class="">mailto:tom@stellard.net</a>>> wrote:<br class=""><br class="">On Tue, Nov 25, 2014 at 01:04:06PM -0500, Matt Arsenault wrote:<br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On Nov 21, 2014, at 1:51 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Nov 16, 2014, at 4:34 AM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Nov 3, 2014, at 3:59 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Oct 17, 2014, at 1:52 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><br class="">On Oct 10, 2014, at 2:08 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a><span class="Apple-converted-space"> </span><<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>>> wrote:<br class=""><br class=""><blockquote type="cite" class="">Hi,<br class=""><br class="">These allows using double inline immediates which before were split into 2 moves to materialize these<br class=""><br class=""><br class=""><0001-R600-SI-Don-t-verify-constant-bus-usage-of-flag-ops.patch><0002-R600-SI-Fix-f64-inline-immediates.patch><0003-R600-SI-Allow-f64-inline-immediates-in-i64-operands.patch><br class=""></blockquote><br class=""><br class="">ping<br class=""></blockquote><br class="">ping<br class=""></blockquote><br class="">Updated patches<br class=""><br class=""><br class=""><0001-R600-SI-Don-t-verify-constant-bus-usage-of-flag-ops.patch><0002-R600-SI-Fix-f64-inline-immediates.patch><0003-R600-SI-Allow-f64-inline-immediates-in-i64-operands.patch><br class=""></blockquote><br class=""><br class="">ping<br class=""></blockquote><br class=""><br class="">Updated patches after SIFoldOperands<br class=""><br class=""></blockquote><br class=""><br class="">The first 2 patches LGTM. Could you rebase the other two so I can test<br class="">them.<br class=""><br class="">-Tom<br class=""><br class=""><br class=""><blockquote type="cite" class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><span class="Apple-converted-space"> </span><<a href="mailto:llvm-commits@cs.uiuc.edu" class="">mailto:llvm-commits@cs.uiuc.edu</a>> <<a href="mailto:llvm-commits@cs.uiuc.edu" class="">mailto:llvm-commits@cs.uiuc.edu</a><span class="Apple-converted-space"> </span><<a href="mailto:llvm-commits@cs.uiuc.edu" class="">mailto:llvm-commits@cs.uiuc.edu</a>>><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><span class="Apple-converted-space"> </span><<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>> <<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>>><br class=""></blockquote></blockquote><br class="">r224078-r224079 for the first two.<br class=""><br class="">Rebased second two:<br class=""></blockquote><br class="">Patch 1: LGTM<br class=""><br class="">Patch 2 breaks the encoding of immediates:<br class=""><br class=""> v_mov_b32_e32 v3, 0x41100000 ; 7E0602FF 00000000<br class=""> v_mov_b32_e32 v2, 0x40c00000 ; 7E0402FF 00000000<br class=""> v_mov_b32_e32 v1, 0x40400000 ; 7E0202FF 00000000<br class=""><br class=""><br class="">-Tom<br class=""></blockquote><br class=""><br class="">I’m not seeing this?:<br class=""><br class="">define void @store_literal(i32 addrspace(1)* %out) {<br class=""> store i32 u0x41100000, i32 addrspace(1)* %out<br class=""> ret void<br class="">}<br class=""><br class="">-show-mc-encoding says<br class="">v_mov_b32_e32 v0, 0x41100000 ; encoding: [0xff,0x02,0x00,0x7e,0x00,0x00,0x10,0x41]<br class=""><br class=""></blockquote><br class=""><br class="">Updated patches<br class=""><br class=""><0001-R600-SI-Remove-unnecessary-check-for-fpimm.patch><br class=""><0002-R600-SI-Allow-f64-inline-immediates-in-i64-operands.patch><br class=""><0003-R600-SI-Remove-handling-of-fpimm.patch><br class=""><br class=""><br class=""></blockquote><br class=""><br class=""></blockquote><br class="">Updated patches that stop the encoder from assuming that inline integer immediate were sign extended to 64-bit. When immediates are split and generally handled other places, the upper bits of the constants are ignored.<br class=""><br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">LGTM for all 3 patches.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">-Tom</span></div></blockquote></div><br class=""><div class=""><br class=""></div><div class="">r229034, r229134, r229135 plus some test changes</div><div class=""><br class=""></div></body></html>