<div dir="ltr">As I described on the IRC channel, please do not add this kind of blank class just to mark something needs to be done there. Please add real code when you are ready instead. This dead code was added in 2013 and it's there doing nothing except confuse developers. The confusion that the class caused is surely small, but that accumulates. I cleaned that kind of things a lot. Please understand that adding and keeping dead code not a good practice.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 12, 2015 at 6:51 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Rui,<br>
<br>
It was a place holder to handle linker scripts. Could you revert this patch.<br>
<br>
Shankar Easwaran<div class="HOEnZb"><div class="h5"><br>
<br>
On 2/12/2015 8:34 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Thu Feb 12 20:34:08 2015<br>
New Revision: 229030<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229030&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=229030&view=rev</a><br>
Log:<br>
Remove class that really does nothing.<br>
<br>
Modified:<br>
lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h<br>
lld/trunk/lib/ReaderWriter/<u></u>ELF/SegmentChunks.h<br>
lld/trunk/lib/ReaderWriter/<u></u>ELF/TODO.txt<br>
lld/trunk/lib/ReaderWriter/<u></u>ELF/TargetLayout.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=229030&r1=229029&r2=229030&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/<u></u>DefaultLayout.h?rev=229030&r1=<u></u>229029&r2=229030&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h Thu Feb 12 20:34:08 2015<br>
@@ -326,16 +326,6 @@ protected:<br>
const ELFLinkingContext &_context;<br>
};<br>
-/// \brief Handle linker scripts. TargetLayouts would derive<br>
-/// from this class to override some of the functionalities.<br>
-template<class ELFT><br>
-class ScriptLayout: public DefaultLayout<ELFT> {<br>
-public:<br>
- ScriptLayout(const ELFLinkingContext &context)<br>
- : DefaultLayout<ELFT>(context)<br>
- {}<br>
-};<br>
-<br>
template <class ELFT><br>
Layout::SectionOrder DefaultLayout<ELFT>::<u></u>getSectionOrder(<br>
StringRef name, int32_t contentType, int32_t contentPermissions) {<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/SegmentChunks.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h?rev=229030&r1=229029&r2=229030&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/<u></u>SegmentChunks.h?rev=229030&r1=<u></u>229029&r2=229030&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/SegmentChunks.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/SegmentChunks.h Thu Feb 12 20:34:08 2015<br>
@@ -30,7 +30,6 @@ namespace lld {<br>
namespace elf {<br>
template <typename ELFT> class DefaultLayout;<br>
-template <typename ELFT> class ScriptLayout;<br>
/// \brief A segment can be divided into segment slices<br>
/// depending on how the segments can be split<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/TODO.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/TODO.txt?rev=229030&r1=229029&r2=229030&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/TODO.txt?rev=<u></u>229030&r1=229029&r2=229030&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/TODO.txt (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/TODO.txt Thu Feb 12 20:34:08 2015<br>
@@ -16,6 +16,4 @@ lib/ReaderWriter/ELF<br>
- Gnu linkonce sections.<br>
-- ScriptLayout<br>
-<br>
- Fix section flags as they appear in input (update content permissions)<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/TargetLayout.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/TargetLayout.h?rev=229030&r1=229029&r2=229030&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/TargetLayout.<u></u>h?rev=229030&r1=229029&r2=<u></u>229030&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/TargetLayout.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/TargetLayout.h Thu Feb 12 20:34:08 2015<br>
@@ -18,10 +18,10 @@ namespace elf {<br>
/// \brief The target can override certain functions in the DefaultLayout<br>
/// class so that the order, the name of the section and the segment type could<br>
/// be changed in the final layout<br>
-template <class ELFT> class TargetLayout : public ScriptLayout<ELFT> {<br>
+template <class ELFT> class TargetLayout : public DefaultLayout<ELFT> {<br>
public:<br>
TargetLayout(const ELFLinkingContext &context)<br>
- : ScriptLayout<ELFT>(context) {}<br>
+ : DefaultLayout<ELFT>(context) {}<br>
};<br>
} // end namespace elf<br>
} // end namespace lld<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>