<div dir="ltr">WindowsSupport.h is in the src tree unfortunately.  It's usually included for files in lib\Support\Windows because they can use #include "WindowsSupport.h", but in this case the project does not live in a different tree, so isn't possible to include that.  Although I'm definitely happy if we can move towards WindowsSupport headers being public.<br></div><br><div class="gmail_quote">On Wed Feb 11 2015 at 1:00:22 PM Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A possible nit below<br>
<br>
On Tue, Feb 10, 2015 at 5:47 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br>
> Author: zturner<br>
> Date: Tue Feb 10 16:47:14 2015<br>
> New Revision: 228756<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228756&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=228756&view=rev</a><br>
> Log:<br>
> Oops.  Don't call Windows functions on non-windows.<br>
><br>
> Modified:<br>
>     llvm/trunk/tools/llvm-pdbdump/<u></u>llvm-pdbdump.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-pdbdump/<u></u>llvm-pdbdump.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp?rev=228756&r1=228755&r2=228756&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/tools/llvm-<u></u>pdbdump/llvm-pdbdump.cpp?rev=<u></u>228756&r1=228755&r2=228756&<u></u>view=diff</a><br>
> ==============================<u></u>==============================<u></u>==================<br>
> --- llvm/trunk/tools/llvm-pdbdump/<u></u>llvm-pdbdump.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-pdbdump/<u></u>llvm-pdbdump.cpp Tue Feb 10 16:47:14 2015<br>
> @@ -15,6 +15,7 @@<br>
><br>
>  #include "llvm/ADT/ArrayRef.h"<br>
>  #include "llvm/ADT/StringExtras.h"<br>
> +#include "llvm/Config/config.h"<br>
>  #include "llvm/DebugInfo/PDB/PDB.h"<br>
>  #include "llvm/DebugInfo/PDB/<u></u>IPDBEnumChildren.h"<br>
>  #include "llvm/DebugInfo/PDB/<u></u>IPDBSession.h"<br>
> @@ -30,7 +31,9 @@<br>
>  #include "llvm/Support/<u></u>PrettyStackTrace.h"<br>
>  #include "llvm/Support/Signals.h"<br>
><br>
> +#if defined(HAVE_DIA_SDK)<br>
>  #include <Windows.h><br>
> +#endif<br>
<br>
Please do not include Windows.h directly, but instead use WindowsSupport.h<br>
<br>
~Aaron<br>
</blockquote></div>