<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div>Depends. If the constant as written is assumed to be 32-bits, it’s legal, as the expression result is then 0xff, which is fine. If it’s assumed to be 64-bits, then there’s a problem, as the result is 0xffffffff000000ff, which isn’t. Since this is a 32-bit architecture, I think a pretty good argument can be made that it should be legal.</div><div><br class=""></div><div>-Jim</div><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 11, 2015, at 3:53 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">*points at Tim and Jim*<div class=""><br class=""></div><div class="">-eric<br class=""><br class=""><div class="gmail_quote">On Wed Feb 11 2015 at 3:50:19 PM Steven Wu <<a href="mailto:stevenwu@apple.com" class="">stevenwu@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Couldn’t find anything related to tilde or how an expression gets evaluated to an immediate in ARM manual. Any authority over ARM assembly language?</div><div style="word-wrap:break-word" class=""><div class=""><br class=""></div><div class="">Steven</div></div><div style="word-wrap:break-word" class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 11, 2015, at 3:37 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">I think the first is to get definite proof on the instruction being legal or not.<br class=""><div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote">On Wed Feb 11 2015 at 3:36:46 PM Steven Wu <<a href="mailto:stevenwu@apple.com" target="_blank" class="">stevenwu@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Unfortunately, I caught this quite late and this commit can no longer back out cleanly. I also don’t have definite proof for such instruction being legal but it certainly looks fine to me. :)<div class="">The easy fix might be to remove this error and shrink the value to 32 bits, but this error message is actually quite useful.</div></div><div style="word-wrap:break-word" class=""><div class=""><br class=""><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 11, 2015, at 3:01 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Hi Steven,<br class=""><br class=""><div class="">Is it a legal instruction? :)</div><div class=""><br class=""></div><div class="">If so, it's been a week, I think we should just revert back to green and add a test that the instruction is assembled properly.</div><div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote">On Wed Feb 11 2015 at 2:58:52 PM Steven Wu <<a href="mailto:stevenwu@apple.com" target="_blank" class="">stevenwu@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Hi Asiri<div class=""><br class=""></div><div class="">Have you had a chance to look at this problem yet? Since the immediates are evaluated as int64_t, I cannot see an easy way to fix this. I don’t think we can allow a false positive for this error message either. Do you have any solution?</div><div class=""><br class=""></div><div class="">Thanks</div></div><div style="word-wrap:break-word" class=""><div class=""><br class=""></div><div class="">Steven</div></div><div style="word-wrap:break-word" class=""><div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 4, 2015, at 12:10 PM, Steven Wu <<a href="mailto:stevenwu@apple.com" target="_blank" class="">stevenwu@apple.com</a>> wrote:</div><br class=""><div class=""><div style="word-wrap:break-word" class="">Hi Asiri<div class=""><br class=""></div><div class="">I see this instruction, which I believe is legal, gets an error now:</div><div class=""><span style="white-space:pre-wrap" class=""> </span>mvn sp, #(~(0xffffff00))</div><div class="">Can you look at this as well? Thanks!</div><div class=""><br class=""></div><div class="">Steven</div><div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Dec 4, 2014, at 7:27 AM, Asiri Rathnayake <<a href="mailto:asiri.rathnayake@gmail.com" target="_blank" class="">asiri.rathnayake@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class="">Should be fixed in r223366<br class=""><br class="">Best,<br class=""><br class="">- Asiri<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Dec 3, 2014 at 6:39 PM, Joerg Sonnenberger <span dir="ltr" class=""><<a href="mailto:joerg@britannica.bec.de" target="_blank" class="">joerg@britannica.bec.de</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Dec 02, 2014 at 10:53:21AM -0000, Asiri Rathnayake wrote:<br class="">
> Author: asiri<br class="">
> Date: Tue Dec 2 04:53:20 2014<br class="">
> New Revision: 223113<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=223113&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=223113&view=rev</a><br class="">
> Log:<br class="">
> Add support for ARM modified-immediate assembly syntax.<br class="">
<br class="">
</span>I see failures like<br class="">
<br class="">
adds r3, r0, #(32 * 4)<br class="">
<br class="">
being rejected now. Can you check if that is your commit?<br class="">
<span class=""><font color="#888888" class=""><br class="">
Joerg<br class="">
</font></span><div class=""><div class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div><br class=""></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class=""></div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></div></div>______________________________<u class=""></u>_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></div></blockquote></div>
</div></blockquote></div><br class=""></div></div></blockquote></div></div></div>
</div></blockquote></div><br class=""></body></html>