<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">I already LGTM the patch for PECOFF.<br>
<br>
On 2/9/2015 5:41 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXguLeDccSK+i7_uQGDHXepMa1inqDGaT2X1BKjjYUK7ceQ@mail.gmail.com"
type="cite">
<pre wrap="">That's what I wanted to ask you. We didn't have this gigantic switch and
lots of break's there but a series of small ifs. You did converted them as
a part of unrelated change (which is the large InputGraph patch) without
any explanation. Yes, the original code looks better to me, and I guess
that's at least part of the reason why the original code was written as it
was. I'm basically trying to restore the original code.
On Fri, Feb 6, 2015 at 7:40 PM, Shankar Kalpathi Easwaran <
<a class="moz-txt-link-abbreviated" href="mailto:shankarke@gmail.com">shankarke@gmail.com</a>> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I really dont understand, Its a matter of style, every developer may
choose to follow different styles. Nothing is written in the coding
convention document about what style to choose over another.
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D7478">http://reviews.llvm.org/D7478</a>
EMAIL PREFERENCES
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>