<div dir="ltr">This needed a pre-commit review. Obviously they are bitmasks just like Unix file permission. Not sure we want to lose that characteristic.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 5, 2015 at 9:29 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: shankare<br>
Date: Thu Feb 5 23:29:49 2015<br>
New Revision: 228381<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228381&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=228381&view=rev</a><br>
Log:<br>
[Core] Update ContentPermissions<br>
<br>
The values are already arranged in ascending order, and all tests still pass.<br>
<br>
Removing the values as its confusing when new enumerations need to be added.<br>
<br>
Modified:<br>
lld/trunk/include/lld/Core/DefinedAtom.h<br>
<br>
Modified: lld/trunk/include/lld/Core/DefinedAtom.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/DefinedAtom.h?rev=228381&r1=228380&r2=228381&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/DefinedAtom.h?rev=228381&r1=228380&r2=228381&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/include/lld/Core/DefinedAtom.h (original)<br>
+++ lld/trunk/include/lld/Core/DefinedAtom.h Thu Feb 5 23:29:49 2015<br>
@@ -157,14 +157,14 @@ public:<br>
// important, because the layout pass may sort atoms by permission if other<br>
// attributes are the same.<br>
enum ContentPermissions {<br>
- perm___ = 0, // mapped as unaccessible<br>
- permR__ = 8, // mapped read-only<br>
- permRW_ = 8 + 2, // mapped readable and writable<br>
- permRW_L = 8 + 2 + 1, // initially mapped r/w, then made read-only<br>
- // loader writable<br>
- permR_X = 8 + 4, // mapped readable and executable<br>
- permRWX = 8 + 2 + 4, // mapped readable and writable and executable<br>
- permUnknown = 16 // unknown or invalid permissions<br>
+ perm___, // mapped as unaccessible<br>
+ permR__, // mapped read-only<br>
+ permRW_, // mapped readable and writable<br>
+ permRW_L, // initially mapped r/w, then made read-only<br>
+ // loader writable<br>
+ permR_X, // mapped readable and executable<br>
+ permRWX, // mapped readable and writable and executable<br>
+ permUnknown // unknown or invalid permissions<br>
};<br>
<br>
enum SectionChoice {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>