<div dir="ltr">Maybe if you have two semicolons at end of line, clang-format moves the second semicolon to the next line for you so that it becomes more visible?</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 5, 2015 at 8:47 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 2/5/2015 10:44 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Feb 5, 2015 at 8:15 PM, Shankar Easwaran <<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>><br>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: shankare<br>
Date: Thu Feb  5 22:15:04 2015<br>
New Revision: 228377<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228377&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=228377&view=rev</a><br>
Log:<br>
[ELF] Speedup creating program headers.<br>
<br>
After the total number of program headers are determined, virtual addresses<br>
and file offsets need not be reassigned for sections whose virtual<br>
addresses and<br>
fileoffsets remained the same.<br>
<br>
This doesnot change any functionality.<br>
<br>
Modified:<br>
     lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=228377&r1=228376&r2=228377&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/<u></u>DefaultLayout.h?rev=228377&r1=<u></u>228376&r2=228377&view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/DefaultLayout.h Thu Feb  5 22:15:04 2015<br>
@@ -755,7 +755,7 @@ DefaultLayout<ELFT>::<u></u>assignVirtualAddres<br>
<br>
    std::sort(_segments.begin(), _segments.end(),<br>
Segment<ELFT>::<u></u>compareSegments);<br>
<br>
-  uint64_t virtualAddress = _context.getBaseAddress();<br>
+  uint64_t baseAddress = _context.getBaseAddress();<br>
<br>
    // HACK: This is a super dirty hack. The elf header and program header<br>
are<br>
    // not part of a section, but we need them to be loaded at the base<br>
address<br>
@@ -774,6 +774,7 @@ DefaultLayout<ELFT>::<u></u>assignVirtualAddres<br>
    firstLoadSegment->prepend(_<u></u>elfHeader);<br>
    bool newSegmentHeaderAdded = true;<br>
    bool virtualAddressAssigned = false;<br>
+  bool fileOffsetAssigned = false;<br>
    while (true) {<br>
      for (auto si : _segments) {<br>
        si->finalize();<br>
@@ -783,8 +784,8 @@ DefaultLayout<ELFT>::<u></u>assignVirtualAddres<br>
      }<br>
      if (!newSegmentHeaderAdded && virtualAddressAssigned)<br>
        break;<br>
-    virtualAddressAssigned = true;<br>
-    uint64_t address = virtualAddress;<br>
+    uint64_t address = baseAddress;<br>
+    ;<br>
<br>
</blockquote>
Stray ';' here.<br>
</blockquote></div></div>
Swear this was not there before clang-format, Will clean this up.<br>
<br>
Thanks for reviewing.<span class="HOEnZb"><font color="#888888"><br>
<br>
Shankar Easwaran<br>
<br>
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>