<div dir="ltr">Why is Size an int? Doesn't Mask.size() return an unsigned value? Is there later use that expects an int?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 3, 2015 at 2:43 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Tue Feb  3 16:43:30 2015<br>
New Revision: 228055<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228055&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=228055&view=rev</a><br>
Log:<br>
[x86] Fix signed vs. unsigned comparison.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=228055&r1=228054&r2=228055&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=228055&r1=228054&r2=228055&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Feb  3 16:43:30 2015<br>
@@ -7820,7 +7820,7 @@ static SDValue lowerVectorShuffleAsBitSh<br>
   SmallBitVector Zeroable = computeZeroableShuffleElements(Mask, V1, V2);<br>
<br>
   int Size = Mask.size();<br>
-  assert(Size == VT.getVectorNumElements() && "Unexpected mask size");<br>
+  assert(Size == (int)VT.getVectorNumElements() && "Unexpected mask size");<br>
<br>
   // PSRL : (little-endian) right bit shift.<br>
   // [  1, zz,  3, zz]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>