<div dir="ltr">Can we get the test back sometime? It was useful :)<br><br>-eric</div><br><div class="gmail_quote">On Tue Feb 03 2015 at 9:10:13 AM NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sorry, I forgot to notice. It depended on targets_to_build.<br>
<br>
2015-02-04 1:29 GMT+09:00 Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>>:<br>
> Note that the test was reverted in r227080 and never added back.<br>
><br>
> On 26 January 2015 at 01:32, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
>> Author: echristo<br>
>> Date: Mon Jan 26 00:32:17 2015<br>
>> New Revision: 227074<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=227074&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=227074&view=rev</a><br>
>> Log:<br>
>> Fix a problem where the AArch64 ELF assembler was failing with<br>
>> -no-exec-stack. This was due to it not deriving from the correct<br>
>> asm info base class and missing the override for the exec<br>
>> stack section query. Added another line to the noexec test<br>
>> line to make sure this doesn't regress.<br>
>><br>
>> Modified:<br>
>> llvm/trunk/lib/Target/AArch64/<u></u>MCTargetDesc/AArch64MCAsmInfo.<u></u>h<br>
>> llvm/trunk/test/MC/ELF/noexec.<u></u>s<br>
>><br>
>> Modified: llvm/trunk/lib/Target/AArch64/<u></u>MCTargetDesc/AArch64MCAsmInfo.<u></u>h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.h?rev=227074&r1=227073&r2=227074&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>AArch64/MCTargetDesc/<u></u>AArch64MCAsmInfo.h?rev=227074&<u></u>r1=227073&r2=227074&view=diff</a><br>
>> ==============================<u></u>==============================<u></u>==================<br>
>> --- llvm/trunk/lib/Target/AArch64/<u></u>MCTargetDesc/AArch64MCAsmInfo.<u></u>h (original)<br>
>> +++ llvm/trunk/lib/Target/AArch64/<u></u>MCTargetDesc/AArch64MCAsmInfo.<u></u>h Mon Jan 26 00:32:17 2015<br>
>> @@ -15,6 +15,7 @@<br>
>> #define LLVM_LIB_TARGET_AARCH64_<u></u>MCTARGETDESC_AARCH64MCASMINFO_<u></u>H<br>
>><br>
>> #include "llvm/MC/MCAsmInfoDarwin.h"<br>
>> +#include "llvm/MC/MCAsmInfoELF.h"<br>
>><br>
>> namespace llvm {<br>
>> class Target;<br>
>> @@ -27,7 +28,7 @@ struct AArch64MCAsmInfoDarwin : public M<br>
>> MCStreamer &Streamer) const override;<br>
>> };<br>
>><br>
>> -struct AArch64MCAsmInfoELF : public MCAsmInfo {<br>
>> +struct AArch64MCAsmInfoELF : public MCAsmInfoELF {<br>
>> explicit AArch64MCAsmInfoELF(StringRef TT);<br>
>> };<br>
>><br>
>><br>
>> Modified: llvm/trunk/test/MC/ELF/noexec.<u></u>s<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ELF/noexec.s?rev=227074&r1=227073&r2=227074&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/MC/<u></u>ELF/noexec.s?rev=227074&r1=<u></u>227073&r2=227074&view=diff</a><br>
>> ==============================<u></u>==============================<u></u>==================<br>
>> --- llvm/trunk/test/MC/ELF/noexec.<u></u>s (original)<br>
>> +++ llvm/trunk/test/MC/ELF/noexec.<u></u>s Mon Jan 26 00:32:17 2015<br>
>> @@ -1,4 +1,5 @@<br>
>> // RUN: llvm-mc -no-exec-stack -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | llvm-readobj -s -t | FileCheck %s<br>
>> +// RUN: llvm-mc -no-exec-stack -filetype=obj -triple aarch64-linux-gnu %s -o - | llvm-readobj -s -t | FileCheck %s<br>
>><br>
>> // CHECK: Section {<br>
>> // CHECK: Index: 4<br>
>><br>
>><br>
>> ______________________________<u></u>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>