<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 1, 2015 at 5:01 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015 Feb 1, at 16:59, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Sun, Feb 1, 2015 at 4:52 PM, Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br>
><br>
> > On 2015 Feb 1, at 16:02, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
> ><br>
> > Formatting and comments<br>
> ><br>
> ><br>
> > <a href="http://reviews.llvm.org/D7324" target="_blank">http://reviews.llvm.org/D7324</a><br>
> ><br>
> > Files:<br>
> >  include/llvm/ADT/STLExtras.h<br>
> >  utils/TableGen/CodeGenRegisters.cpp<br>
> >  utils/TableGen/CodeGenRegisters.h<br>
> >  utils/TableGen/RegisterInfoEmitter.cpp<br>
> ><br>
> > EMAIL PREFERENCES<br>
> >  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
> > <D7324.19120.patch><br>
><br>
> It's a slight shame to lose the `assert()`s in `Less` and `Equal`, but<br>
> given that we have the ASan bots they were probably low value anyway.<br>
><br>
> Oh, meant to add/mention that they could be added back into the deref::operator() template if desired.<br>
<br>
</span>I was thinking that the assertions wouldn't work with smart pointers,<br>
but I suppose they usually have an `operator bool()` defined.<br>
<br>
I do prefer the asserting version.<br></blockquote><div><br>Readded the assertions, removed perfect forwarding (since the expressions are used more than once, perfect forwarding doesn't apply).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> - David<br>
><br>
><br>
> LGTM.<br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div></div>