<div dir="ltr">Hi Justin, <div><br></div><div>Do you have time to take a look at this patch? <br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 30, 2015 at 7:35 PM, Jingyue Wu <span dir="ltr"><<a href="mailto:jingyue@google.com" target="_blank">jingyue@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">================<br>
Comment at: lib/Target/NVPTX/NVPTXAsmPrinter.cpp:426<br>
@@ +425,3 @@<br>
+// TODO(jingyue): consider "#pragma unroll 1" which is equivalent to "#pragma<br>
+// nounroll".<br>
+bool NVPTXAsmPrinter::isLoopHeaderOfNoUnroll(<br>
----------------<br>
</span><span class="">meheff wrote:<br>
> FYI the loop unrolling pass should replace instances of "llvm.loop.unroll.count 1" from "#pragma unroll 1" with llvm.loop.unroll.disable.<br>
</span>Ack'ed.<br>
<span class=""><br>
================<br>
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:237<br>
@@ -236,3 +236,3 @@<br>
 // returned.<br>
 static const MDNode *GetUnrollMetadata(const Loop *L, StringRef Name) {<br>
   MDNode *LoopID = L->getLoopID();<br>
----------------<br>
</span><span class="">meheff wrote:<br>
> How about calling this function GetUnrollMetadataForLoop to avoid colliding with the new function you added?<br>
</span>Done.<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D7041" target="_blank">http://reviews.llvm.org/D7041</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div></div>