<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">After some more investigation, I think the initializeAllAnalysisInfo() track is a red herring. It was actually hot in the prior profile as well, just buried behind locking-related things. I think this change should go ahead.<div class=""><br class=""></div><div class="">—Owen</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 27, 2015, at 5:26 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="">chandlerc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">To summarize the discussion on IRC:<div class=""><br class=""></div><div class="">This hot code path doesn't really seem to be due to my patch. If it is, I can't explain why. I definitely can't explain why without some steps to reproduce.</div><div class=""><br class=""></div><div class="">This patch essentially erases all the performance hits I can find any way to measure of the pthread locks, so I'll wait for more information from you or the others that have measured more significant issues here. Let me know what you'd like me to do next.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jan 27, 2015 at 4:56 PM, Owen Anderson <span dir="ltr" class=""><<a href="mailto:resistor@mac.com" target="_blank" class="">resistor@mac.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Hi Chandler,<br class="">
<br class="">
In my measurements, this captures about half of the regression, i.e. the regression goes from ~20% to ~10%. While the reader/writer locks are gone from the profile, several other PassManager related pieces of code have jumped up to take their place:<br class="">
<br class="">
</span>—Owen<br class="">
<br class="">
- F362108: ThreadProfile2.png <<a href="http://reviews.llvm.org/F362108" target="_blank" class="">http://reviews.llvm.org/F362108</a>><br class="">
<br class="">
<br class="">
<a href="http://reviews.llvm.org/D7213" target="_blank" class="">http://reviews.llvm.org/D7213</a><br class="">
<br class="">
EMAIL PREFERENCES<br class="">
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>