<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jan 23, 2015 at 7:14 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: eugenis<br>
Date: Fri Jan 23 09:14:27 2015<br>
New Revision: 226913<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226913&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=226913&view=rev</a><br>
Log:<br>
[sanitizer] Fix an edge case in MemoryRangeIsAvailable.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc?rev=226913&r1=226912&r2=226913&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc?rev=226913&r1=226912&r2=226913&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix.cc Fri Jan 23 09:14:27 2015<br>
@@ -237,7 +237,8 @@ bool MemoryRangeIsAvailable(uptr range_s<br>
   while (proc_maps.Next(&start, &end,<br>
                         /*offset*/0, /*filename*/0, /*filename_size*/0,<br>
                         /*protection*/0)) {<br>
-    if (!IntervalsAreSeparate(start, end, range_start, range_end))<br>
+    CHECK_NE(0, end);<br>
+    if (!IntervalsAreSeparate(start, end - 1, range_start, range_end))<br>
       return false;<br>
   }<br></blockquote><div><br></div><div>I don't believe this is the correct fix. IntervalsAreSeparate should treat its arguments as [start1, end1) and [start2, end2), and</div><div>therefore check that (end1 <= start2) || (end2 <= start1);</div><div><br></div><div>Otherwise, your change should also subtract one from range_end.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   return true;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></div>