<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">> The extra nots/checks/suffixes don't seem important to the essence of this test.<br>
<br>
I agree. I'll prune that in the commit.<br>
<br>
> I'll leave it to someone MIPS-y to sign off on the actual code change (unless you were only seeking review of the test case part of things & you're confident in the code change itself).<br>
<br>
I'd normally wait for a full pre-commit sign-off regardless of my confidence level but it's a safe change and it should make the builder green again so I think it's best to make an exception.<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF979752"><font color="#000000" face="Tahoma" size="2"><b>From:</b> David Blaikie [dblaikie@gmail.com]<br>
<b>Sent:</b> 22 January 2015 17:47<br>
<b>To:</b> reviews+D7050+public+e22ff8356bd9a5ae@reviews.llvm.org<br>
<b>Cc:</b> Daniel Sanders; Vladimir Medic; llvm-commits@cs.uiuc.edu; ehostunreach<br>
<b>Subject:</b> Re: [PATCH] [mips] Fix 'jumpy' debug line info around calls.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Jan 22, 2015 at 3:09 AM, Daniel Sanders <span dir="ltr">
<<a href="mailto:daniel.sanders@imgtec.com" target="_blank">daniel.sanders@imgtec.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Test the .loc positioning more directly by matching the %call16 reloc.<br>
</blockquote>
<div><br>
Cool (I don't know anything about the MIPS asm/reloc syntax, etc, so I'll take your word for that)<br>
<br>
Maybe this could be simpler:<br>
<br>
CHECK: .loc 1 3<br>
CHECK-NOT: .loc<br>
CHECK: %call16(f1)<br>
<br>
CHECK: .loc 1 4<br>
CHECK-NOT: .loc<br>
CHECK: %call16(f1)<br>
<br>
The extra nots/checks/suffixes don't seem important to the essence of this test.<br>
<br>
Anyway - I'm generally good with the test, but I'll leave it to someone MIPS-y to sign off on the actual code change (unless you were only seeking review of the test case part of things & you're confident in the code change itself).<br>
<br>
Thanks!<br>
- David<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<span class="im HOEnZb"><br>
<br>
<a href="http://reviews.llvm.org/D7050" target="_blank">http://reviews.llvm.org/D7050</a><br>
<br>
Files:<br>
lib/Target/Mips/Mips16ISelLowering.cpp<br>
lib/Target/Mips/MipsISelLowering.cpp<br>
lib/Target/Mips/MipsISelLowering.h<br>
</span>
<div class="HOEnZb">
<div class="h5"> test/DebugInfo/Mips/fn-call-line.ll<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">
http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</body>
</html>