<div dir="ltr">So you added back the REQUIRES line that was removed in r<span style="color:rgb(0,0,0)">213390</span>. Why?<br><div><br></div><div>REQUIRES line should generally be avoided because all pasts should pass on all platforms. Is there any reason this test doesn't pass on non-MIPS machines?</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 23, 2015 at 2:32 PM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:me@filcab.net" target="_blank">me@filcab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Fri Jan 23 16:32:05 2015<br>
New Revision: 226950<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226950&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=226950&view=rev</a><br>
Log:<br>
[lld] Re-add REQUIRES line<br>
<br>
Please don't remove REQUIRES lines when refreshing tests.<br>
<br>
Modified:<br>
    lld/trunk/test/elf/Mips/base-address.test<br>
<br>
Modified: lld/trunk/test/elf/Mips/base-address.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/base-address.test?rev=226950&r1=226949&r2=226950&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/Mips/base-address.test?rev=226950&r1=226949&r2=226950&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/elf/Mips/base-address.test (original)<br>
+++ lld/trunk/test/elf/Mips/base-address.test Fri Jan 23 16:32:05 2015<br>
@@ -1,3 +1,5 @@<br>
+# REQUIRES: Mips<br>
+<br>
 # Check executable base address configuration. Base address should be<br>
 # equal to 0x400000 and the MIPS_BASE_ADDRESS dynamic tag's value should<br>
 # be the same.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>