<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 22, 2015 at 3:09 AM, Daniel Sanders <span dir="ltr"><<a href="mailto:daniel.sanders@imgtec.com" target="_blank">daniel.sanders@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Test the .loc positioning more directly by matching the %call16 reloc.<br></blockquote><div><br>Cool (I don't know anything about the MIPS asm/reloc syntax, etc, so I'll take your word for that)<br><br>Maybe this could be simpler:<br><br>CHECK: .loc 1 3<br>CHECK-NOT: .loc<br>CHECK: %call16(f1)<br><br>CHECK: .loc 1 4<br>CHECK-NOT: .loc<br>CHECK: %call16(f1)<br><br>The extra nots/checks/suffixes don't seem important to the essence of this test.<br><br>Anyway - I'm generally good with the test, but I'll leave it to someone MIPS-y to sign off on the actual code change (unless you were only seeking review of the test case part of things & you're confident in the code change itself).<br><br>Thanks!<br>- David<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="im HOEnZb"><br>
<br>
<a href="http://reviews.llvm.org/D7050" target="_blank">http://reviews.llvm.org/D7050</a><br>
<br>
Files:<br>
  lib/Target/Mips/Mips16ISelLowering.cpp<br>
  lib/Target/Mips/MipsISelLowering.cpp<br>
  lib/Target/Mips/MipsISelLowering.h<br>
</span><div class="HOEnZb"><div class="h5">  test/DebugInfo/Mips/fn-call-line.ll<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</div></div></blockquote></div><br></div></div>