<span style="line-height:19.7999992370605px">Hi Duncan,</span><br style="line-height:19.7999992370605px"><br style="line-height:19.7999992370605px"><span style="line-height:19.7999992370605px">This has broken down "ninja check-asan" on 32-bit Windows.</span><br><div><div>Assertion failed: Context.hasReplaceableUses() && "Expected RAUW support", file C:\src\llvm_bot\slave\win\build\llvm\include\llvm/IR/Metadata.h, line 976</div><div style="line-height:19.7999992370605px"><br></div></div><div style="line-height:19.7999992370605px">It seems to be hard to revert now...</div><div style="line-height:19.7999992370605px">You've committed a lot of small changes in a very short timeframe -- I assume you're using git?  Is there a reason why you don't squash your changes before committing?  It makes finding bad commits / reverting harder...</div><div><span style="line-height:19.7999992370605px"><br></span></div><br><div class="gmail_quote">On Mon Jan 19 2015 at 10:30:36 PM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com">dexonsmith@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dexonsmith<br>
Date: Mon Jan 19 13:26:24 2015<br>
New Revision: 226490<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226490&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=226490&view=rev</a><br>
Log:<br>
IR: Remove direct comparisons against Metadata::Storage, NFC<br>
<br>
Modified:<br>
    llvm/trunk/lib/IR/Metadata.cpp<br>
<br>
Modified: llvm/trunk/lib/IR/Metadata.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Metadata.cpp?rev=226490&r1=226489&r2=226490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/IR/<u></u>Metadata.cpp?rev=226490&r1=<u></u>226489&r2=226490&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/IR/Metadata.cpp (original)<br>
+++ llvm/trunk/lib/IR/Metadata.cpp Mon Jan 19 13:26:24 2015<br>
@@ -402,7 +402,7 @@ MDNode::MDNode(LLVMContext &Context, uns<br>
   for (unsigned I = 0, E = MDs.size(); I != E; ++I)<br>
     setOperand(I, MDs[I]);<br>
<br>
-  if (Storage == Temporary)<br>
+  if (isTemporary())<br>
     this->Context.makeReplaceable(<br>
         make_unique<<u></u>ReplaceableMetadataImpl>(<u></u>Context));<br>
 }<br>
@@ -416,7 +416,7 @@ static bool isOperandUnresolved(Metadata<br>
 UniquableMDNode::<u></u>UniquableMDNode(LLVMContext &C, unsigned ID,<br>
                                  StorageType Storage, ArrayRef<Metadata *> Vals)<br>
     : MDNode(C, ID, Storage, Vals) {<br>
-  if (Storage != Uniqued)<br>
+  if (!isUniqued())<br>
     return;<br>
<br>
   // Check whether any operands are unresolved, requiring re-uniquing.<br>
@@ -432,7 +432,7 @@ UniquableMDNode::<u></u>UniquableMDNode(LLVMCon<br>
 }<br>
<br>
 void UniquableMDNode::resolve() {<br>
-  assert(Storage == Uniqued && "Expected this to be uniqued");<br>
+  assert(isUniqued() && "Expected this to be uniqued");<br>
   assert(!isResolved() && "Expected this to be unresolved");<br>
<br>
   // Move the map, so that this immediately looks resolved.<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>