<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Eric,<div class=""><br class=""></div><div class="">Oddly the code works, in this case prints the correct size. But only fails for this bot on this test. I’m actively working on a better fix. If you really feel this code needs to be reverted while make this fix I can do that.</div><div class=""><br class=""></div><div class="">Kev</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 16, 2015, at 11:15 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Kevin,</div><div class=""><br class=""></div>Should you instead revert the code until you can get it working? I'm just concerned with the deletion and no real way of knowing what the actual issue was here.<br class=""><div class=""><br class=""></div><div class="">Thanks! and yeah, breakage happens :)</div><div class=""><br class=""></div><div class="">-eric</div><br class=""><div class="gmail_quote">On Fri Jan 16 2015 at 11:06:57 AM Kevin Enderby <<a href="mailto:enderby@apple.com" class="">enderby@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">It was a late night guess, and an incorrect one. I removed the test in <font face="Helvetica Neue" class="">r226241 last night before I went home and am working on a “better guess now” :)</font><div class=""><font face="Helvetica Neue" class=""><br class=""></font></div><div class=""><font face="Helvetica Neue" class="">Again sorry for the breakage,</font></div><div class=""><font face="Helvetica Neue" class="">Kev</font></div></div><div style="word-wrap:break-word" class=""><div class=""><font face="Helvetica Neue" class=""><br class=""></font><div class=""><blockquote type="cite" class=""><div class="">On Jan 16, 2015, at 11:04 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:</div><br class=""><div class="">Hi Kevin,<br class=""><br class=""><div class="">How was this supposed to fix the failure?</div><div class=""><br class=""></div><div class="">-eric</div><br class=""><div class="gmail_quote">On Thu Jan 15 2015 at 4:31:32 PM Kevin Enderby <<a href="mailto:enderby@apple.com" target="_blank" class="">enderby@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enderby<br class="">
Date: Thu Jan 15 18:27:31 2015<br class="">
New Revision: 226232<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226232&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>project?rev=226232&view=rev</a><br class="">
Log:<br class="">
This should fix the build bot clang-cmake-armv7-a15-full failing on<br class="">
the macho-archive-headers.test added with r226228.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Object/Archive.<u class=""></u>cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Object/Archive.<u class=""></u>cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/Archive.cpp?rev=226232&r1=226231&r2=226232&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<u class=""></u>project/llvm/trunk/lib/Object/<u class=""></u>Archive.cpp?rev=226232&r1=<u class=""></u>226231&r2=226232&view=diff</a><br class="">
==============================<u class=""></u>==============================<u class=""></u>==================<br class="">
--- llvm/trunk/lib/Object/Archive.<u class=""></u>cpp (original)<br class="">
+++ llvm/trunk/lib/Object/Archive.<u class=""></u>cpp Thu Jan 15 18:27:31 2015<br class="">
@@ -111,8 +111,6 @@ uint64_t Archive::Child::getSize() const<br class="">
}<br class="">
<br class="">
uint64_t Archive::Child::getRawSize() const {<br class="">
- if (Parent->IsThin)<br class="">
- return getHeader()->getSize();<br class="">
return Data.size();<br class="">
}<br class="">
<br class="">
<br class="">
<br class="">
______________________________<u class=""></u>_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/<u class=""></u>mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></blockquote></div>
</div></blockquote></div><br class=""></div></body></html>